summaryrefslogtreecommitdiffstats
path: root/content/browser/renderer_host
diff options
context:
space:
mode:
authormkosiba@chromium.org <mkosiba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-03 15:55:49 +0000
committermkosiba@chromium.org <mkosiba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-03 15:55:49 +0000
commitc31a8480c5ed4f8e5928422cd4fc2656997f5854 (patch)
treec571d562238af6e5fa5edb4a4ca6092ae87ab822 /content/browser/renderer_host
parent834e5492ab743a663ce532d6087b2ca0ceea0162 (diff)
downloadchromium_src-c31a8480c5ed4f8e5928422cd4fc2656997f5854.zip
chromium_src-c31a8480c5ed4f8e5928422cd4fc2656997f5854.tar.gz
chromium_src-c31a8480c5ed4f8e5928422cd4fc2656997f5854.tar.bz2
Migrate addMessageToConsole API to RenderFrame.
BUG=304341 NOTRY=true Review URL: https://codereview.chromium.org/217183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261424 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/renderer_host')
-rw-r--r--content/browser/renderer_host/render_view_host_delegate.cc10
-rw-r--r--content/browser/renderer_host/render_view_host_delegate.h9
-rw-r--r--content/browser/renderer_host/render_view_host_impl.cc18
-rw-r--r--content/browser/renderer_host/render_view_host_impl.h4
4 files changed, 0 insertions, 41 deletions
diff --git a/content/browser/renderer_host/render_view_host_delegate.cc b/content/browser/renderer_host/render_view_host_delegate.cc
index 46206d1..6d19fa9 100644
--- a/content/browser/renderer_host/render_view_host_delegate.cc
+++ b/content/browser/renderer_host/render_view_host_delegate.cc
@@ -18,16 +18,6 @@ bool RenderViewHostDelegate::OnMessageReceived(RenderViewHost* render_view_host,
return false;
}
-bool RenderViewHostDelegate::AddMessageToConsole(
- int32 level, const base::string16& message, int32 line_no,
- const base::string16& source_id) {
- return false;
-}
-
-const GURL& RenderViewHostDelegate::GetURL() const {
- return GURL::EmptyGURL();
-}
-
WebContents* RenderViewHostDelegate::GetAsWebContents() {
return NULL;
}
diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h
index 618ab6f..0e2ab50 100644
--- a/content/browser/renderer_host/render_view_host_delegate.h
+++ b/content/browser/renderer_host/render_view_host_delegate.h
@@ -83,9 +83,6 @@ class CONTENT_EXPORT RenderViewHostDelegate {
virtual bool OnMessageReceived(RenderViewHost* render_view_host,
const IPC::Message& message);
- // Gets the URL that is currently being displayed, if there is one.
- virtual const GURL& GetURL() const;
-
// Return this object cast to a WebContents, if it is one. If the object is
// not a WebContents, returns NULL. DEPRECATED: Be sure to include brettw or
// jam as reviewers before you use this method. http://crbug.com/82582
@@ -184,12 +181,6 @@ class CONTENT_EXPORT RenderViewHostDelegate {
bool is_reload,
IPC::Message* reply_msg) {}
- // A message was added to to the console.
- virtual bool AddMessageToConsole(int32 level,
- const base::string16& message,
- int32 line_no,
- const base::string16& source_id);
-
// Return a dummy RendererPreferences object that will be used by the renderer
// associated with the owning RenderViewHost.
virtual RendererPreferences GetRendererPrefs(
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index c5ed9d5..c6fc3bf 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -1102,7 +1102,6 @@ bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(DragHostMsg_TargetDrop_ACK, OnTargetDropACK)
IPC_MESSAGE_HANDLER(ViewHostMsg_TakeFocus, OnTakeFocus)
IPC_MESSAGE_HANDLER(ViewHostMsg_FocusedNodeChanged, OnFocusedNodeChanged)
- IPC_MESSAGE_HANDLER(ViewHostMsg_AddMessageToConsole, OnAddMessageToConsole)
IPC_MESSAGE_HANDLER(ViewHostMsg_ClosePage_ACK, OnClosePageACK)
#if defined(OS_ANDROID)
IPC_MESSAGE_HANDLER(ViewHostMsg_SelectionRootBoundsChanged,
@@ -1494,23 +1493,6 @@ void RenderViewHostImpl::OnFocusedNodeChanged(bool is_editable_node) {
Details<const bool>(&is_editable_node));
}
-void RenderViewHostImpl::OnAddMessageToConsole(
- int32 level,
- const base::string16& message,
- int32 line_no,
- const base::string16& source_id) {
- if (delegate_->AddMessageToConsole(level, message, line_no, source_id))
- return;
-
- // Pass through log level only on WebUI pages to limit console spew.
- int32 resolved_level = HasWebUIScheme(delegate_->GetURL()) ? level : 0;
-
- if (resolved_level >= ::logging::GetMinLogLevel()) {
- logging::LogMessage("CONSOLE", line_no, resolved_level).stream() << "\"" <<
- message << "\", source: " << source_id << " (" << line_no << ")";
- }
-}
-
void RenderViewHostImpl::OnUserGesture() {
delegate_->OnUserGesture();
}
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index ba6050d..ea52a8d 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -554,10 +554,6 @@ class CONTENT_EXPORT RenderViewHostImpl
void OnTargetDropACK();
void OnTakeFocus(bool reverse);
void OnFocusedNodeChanged(bool is_editable_node);
- void OnAddMessageToConsole(int32 level,
- const base::string16& message,
- int32 line_no,
- const base::string16& source_id);
void OnUpdateInspectorSetting(const std::string& key,
const std::string& value);
void OnClosePageACK();