summaryrefslogtreecommitdiffstats
path: root/content/browser/shared_worker
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2015-12-25 22:16:36 -0800
committerCommit bot <commit-bot@chromium.org>2015-12-26 06:17:30 +0000
commit36b6aec9a5f4953e2177146503096ca7de00cc36 (patch)
treea1d68bc1fab0b8127d7f47d3f9b3550eada5ac15 /content/browser/shared_worker
parent2729e442b1172c5094503a03fe356c8580bb919d (diff)
downloadchromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.zip
chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.gz
chromium_src-36b6aec9a5f4953e2177146503096ca7de00cc36.tar.bz2
Convert Pass()→std::move() in //content/browser
BUG=557422 Review URL: https://codereview.chromium.org/1545243002 Cr-Commit-Position: refs/heads/master@{#366894}
Diffstat (limited to 'content/browser/shared_worker')
-rw-r--r--content/browser/shared_worker/shared_worker_service_impl.cc23
-rw-r--r--content/browser/shared_worker/shared_worker_service_impl_unittest.cc2
2 files changed, 13 insertions, 12 deletions
diff --git a/content/browser/shared_worker/shared_worker_service_impl.cc b/content/browser/shared_worker/shared_worker_service_impl.cc
index 400541a..46d15bc 100644
--- a/content/browser/shared_worker/shared_worker_service_impl.cc
+++ b/content/browser/shared_worker/shared_worker_service_impl.cc
@@ -5,10 +5,10 @@
#include "content/browser/shared_worker/shared_worker_service_impl.h"
#include <stddef.h>
-
#include <algorithm>
#include <iterator>
#include <set>
+#include <utility>
#include <vector>
#include "base/callback.h"
@@ -130,7 +130,7 @@ class SharedWorkerServiceImpl::SharedWorkerPendingInstance {
explicit SharedWorkerPendingInstance(
scoped_ptr<SharedWorkerInstance> instance)
- : instance_(instance.Pass()) {}
+ : instance_(std::move(instance)) {}
~SharedWorkerPendingInstance() {}
SharedWorkerInstance* instance() { return instance_.get(); }
SharedWorkerInstance* release_instance() { return instance_.release(); }
@@ -311,13 +311,14 @@ void SharedWorkerServiceImpl::CreateWorker(
*creation_error = blink::WebWorkerCreationErrorSecureContextMismatch;
return;
}
- pending->AddRequest(request.Pass());
+ pending->AddRequest(std::move(request));
return;
}
scoped_ptr<SharedWorkerPendingInstance> pending_instance(
- new SharedWorkerPendingInstance(instance.Pass()));
- pending_instance->AddRequest(request.Pass());
- ReserveRenderProcessToCreateWorker(pending_instance.Pass(), creation_error);
+ new SharedWorkerPendingInstance(std::move(instance)));
+ pending_instance->AddRequest(std::move(request));
+ ReserveRenderProcessToCreateWorker(std::move(pending_instance),
+ creation_error);
}
void SharedWorkerServiceImpl::ForwardToWorker(
@@ -530,7 +531,7 @@ void SharedWorkerServiceImpl::ReserveRenderProcessToCreateWorker(
worker_route_id,
is_new_worker),
s_try_increment_worker_ref_count_));
- pending_instances_.set(pending_instance_id, pending_instance.Pass());
+ pending_instances_.set(pending_instance_id, std::move(pending_instance));
}
void SharedWorkerServiceImpl::RenderProcessReservedCallback(
@@ -556,7 +557,7 @@ void SharedWorkerServiceImpl::RenderProcessReservedCallback(
// Retry reserving a renderer process if the existed Shared Worker was
// destroyed on IO thread while reserving the renderer process on UI
// thread.
- ReserveRenderProcessToCreateWorker(pending_instance.Pass(), NULL);
+ ReserveRenderProcessToCreateWorker(std::move(pending_instance), NULL);
return;
}
pending_instance->RegisterToSharedWorkerHost(existing_host);
@@ -569,7 +570,7 @@ void SharedWorkerServiceImpl::RenderProcessReservedCallback(
pending_instance->RemoveRequest(worker_process_id);
// Retry reserving a renderer process if the requested renderer process was
// destroyed on IO thread while reserving the renderer process on UI thread.
- ReserveRenderProcessToCreateWorker(pending_instance.Pass(), NULL);
+ ReserveRenderProcessToCreateWorker(std::move(pending_instance), NULL);
return;
}
scoped_ptr<SharedWorkerHost> host(new SharedWorkerHost(
@@ -579,7 +580,7 @@ void SharedWorkerServiceImpl::RenderProcessReservedCallback(
const base::string16 name = host->instance()->name();
host->Start(pause_on_start);
worker_hosts_.set(std::make_pair(worker_process_id, worker_route_id),
- host.Pass());
+ std::move(host));
FOR_EACH_OBSERVER(
WorkerServiceObserver,
observers_,
@@ -599,7 +600,7 @@ void SharedWorkerServiceImpl::RenderProcessReserveFailedCallback(
return;
pending_instance->RemoveRequest(worker_process_id);
// Retry reserving a renderer process.
- ReserveRenderProcessToCreateWorker(pending_instance.Pass(), NULL);
+ ReserveRenderProcessToCreateWorker(std::move(pending_instance), NULL);
}
SharedWorkerHost* SharedWorkerServiceImpl::FindSharedWorkerHost(
diff --git a/content/browser/shared_worker/shared_worker_service_impl_unittest.cc b/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
index f2f3015..1c7d409 100644
--- a/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
+++ b/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
@@ -210,7 +210,7 @@ class MockRendererProcessHost {
CHECK(queued_messages_.size());
scoped_ptr<IPC::Message> msg(*queued_messages_.begin());
queued_messages_.weak_erase(queued_messages_.begin());
- return msg.Pass();
+ return msg;
}
void FastShutdownIfPossible() {