diff options
author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-17 22:43:31 +0000 |
---|---|---|
committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-17 22:43:31 +0000 |
commit | fc006cac2085cf5bcc3be856cbf9085fba11aa4b (patch) | |
tree | dd03da9ff585773d2dd0558cbbff11da563a73e4 /content/browser/tracing/tracing_ui.cc | |
parent | d4d844a29b271cabb96ca6d5bdccce8056c1b16f (diff) | |
download | chromium_src-fc006cac2085cf5bcc3be856cbf9085fba11aa4b.zip chromium_src-fc006cac2085cf5bcc3be856cbf9085fba11aa4b.tar.gz chromium_src-fc006cac2085cf5bcc3be856cbf9085fba11aa4b.tar.bz2 |
Fix incorrect checking of file_util::WriteFile() return results.
Review URL: https://chromiumcodereview.appspot.com/23865006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223723 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/tracing/tracing_ui.cc')
-rw-r--r-- | content/browser/tracing/tracing_ui.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/content/browser/tracing/tracing_ui.cc b/content/browser/tracing/tracing_ui.cc index 7793adb..15bd2cf 100644 --- a/content/browser/tracing/tracing_ui.cc +++ b/content/browser/tracing/tracing_ui.cc @@ -13,6 +13,7 @@ #include "base/file_util.h" #include "base/json/string_escape.h" #include "base/memory/scoped_ptr.h" +#include "base/safe_numerics.h" #include "base/strings/string_number_conversions.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" @@ -269,7 +270,8 @@ void ReadTraceFileCallback(TaskProxy* proxy, const base::FilePath& path) { void WriteTraceFileCallback(TaskProxy* proxy, const base::FilePath& path, std::string* contents) { - if (!file_util::WriteFile(path, contents->c_str(), contents->size())) + int size = base::checked_numeric_cast<int>(contents->size()); + if (file_util::WriteFile(path, contents->c_str(), size) != size) return; BrowserThread::PostTask( @@ -363,7 +365,7 @@ void TracingMessageHandler::OnSaveTraceFile(const base::ListValue* list) { if (select_trace_file_dialog_.get()) return; - DCHECK(list->GetSize() == 1); + DCHECK_EQ(1U, list->GetSize()); std::string* trace_data = new std::string(); bool ok = list->GetString(0, trace_data); |