diff options
author | vadimt <vadimt@chromium.org> | 2014-12-30 14:17:47 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-30 22:18:35 +0000 |
commit | 6f25e7abcbb96a0c5eefae918f0302f7d89e21b0 (patch) | |
tree | 94d3891aaf90d4ca9af54b1b2db2f6cf6ae9c520 /content/browser/webui/url_data_manager_backend.cc | |
parent | 7c9665ef172a0260ac0b06040a9459026121cdde (diff) | |
download | chromium_src-6f25e7abcbb96a0c5eefae918f0302f7d89e21b0.zip chromium_src-6f25e7abcbb96a0c5eefae918f0302f7d89e21b0.tar.gz chromium_src-6f25e7abcbb96a0c5eefae918f0302f7d89e21b0.tar.bz2 |
Instrumenting ReadRawData and InformDelegateDownloadProgress to find jank.
Prior instrumentations showed that:
ReadRawData = 16 jph
InformDelegateDownloadProgress = 4.8 jph
Instrumenting deeper.
The jank in InformDelegateDownloadProgress is a surprise since this method does nothing but posting a task. But still, who knows, and I'm instrumenting it too.
BUG=423948
TBR=jianli@chromium.org, jhawkins@chromium.org, zork@chromium.org, jochen@chromium.org, tzik@chromium.org
Review URL: https://codereview.chromium.org/821073003
Cr-Commit-Position: refs/heads/master@{#309783}
Diffstat (limited to 'content/browser/webui/url_data_manager_backend.cc')
-rw-r--r-- | content/browser/webui/url_data_manager_backend.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/content/browser/webui/url_data_manager_backend.cc b/content/browser/webui/url_data_manager_backend.cc index 9e12864..409e6bd 100644 --- a/content/browser/webui/url_data_manager_backend.cc +++ b/content/browser/webui/url_data_manager_backend.cc @@ -17,6 +17,7 @@ #include "base/memory/ref_counted_memory.h" #include "base/memory/weak_ptr.h" #include "base/message_loop/message_loop.h" +#include "base/profiler/scoped_tracker.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" #include "content/browser/appcache/view_appcache_internals_job.h" @@ -349,6 +350,11 @@ void URLRequestChromeJob::DataAvailable(base::RefCountedMemory* bytes) { bool URLRequestChromeJob::ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) { + // TODO(vadimt): Remove ScopedTracker below once crbug.com/423948 is fixed. + tracked_objects::ScopedTracker tracking_profile( + FROM_HERE_WITH_EXPLICIT_FUNCTION( + "423948 URLRequestChromeJob::ReadRawData")); + if (!data_.get()) { SetStatus(net::URLRequestStatus(net::URLRequestStatus::IO_PENDING, 0)); DCHECK(!pending_buf_.get()); |