Page zoom improvements:

1. Change from using zoom levels to a range of preset zoom factors (percentages). Zoom levels are the values that WebKit uses for page zoom. While zoom levels are simple to implement, they result in undesirable percentages like 57%, 144%, 207%, etc. Changing to zoom factors gives us user-friendly zoom percentages.
2. Increase the range of supported zoom values. A user can now zoom between 25% to 500%.
3. Use an epsilon value when comparing zoom floating point values. The previous version was doing an equality comparison of double values which may not always work as expected.

BUG=71484
TEST=Exercise zoom in/out via the wrench menu; exercise default page zoom setting in options window
Review URL: http://codereview.chromium.org/8528011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111087 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 74 insertions, 0 deletions

diff --git a/content/browser/webui/web_ui_unittest.cc b/content/browser/webui/web_ui_unittest.cc
new file mode 100644
index 0000000..93e597f
--- /dev/null
+++ b/content/browser/webui/web_ui_unittest.cc
@@ -0,0 +1,74 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/webui/web_ui.h"
+
+#include "base/string16.h"
+#include "base/values.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class TestWebUIMessageHandler : public WebUIMessageHandler {
+ public:
+  TestWebUIMessageHandler() {}
+  virtual ~TestWebUIMessageHandler() {}
+
+ protected:
+  virtual void RegisterMessages() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestWebUIMessageHandler);
+};
+
+TEST(WebUIMessageHandlerTest, ExtractIntegerValue) {
+  TestWebUIMessageHandler handler;
+
+  ListValue list;
+  int value, zero_value = 0, neg_value = -1234, pos_value = 1234;
+
+  list.Append(Value::CreateIntegerValue(zero_value));
+  EXPECT_TRUE(handler.ExtractIntegerValue(&list, &value));
+  EXPECT_EQ(value, zero_value);
+  list.Clear();
+
+  list.Append(Value::CreateIntegerValue(neg_value));
+  EXPECT_TRUE(handler.ExtractIntegerValue(&list, &value));
+  EXPECT_EQ(value, neg_value);
+  list.Clear();
+
+  list.Append(Value::CreateIntegerValue(pos_value));
+  EXPECT_TRUE(handler.ExtractIntegerValue(&list, &value));
+  EXPECT_EQ(value, pos_value);
+}
+
+TEST(WebUIMessageHandlerTest, ExtractDoubleValue) {
+  TestWebUIMessageHandler handler;
+
+  ListValue list;
+  double value, zero_value = 0.0, neg_value = -1234.5, pos_value = 1234.5;
+
+  list.Append(Value::CreateDoubleValue(zero_value));
+  EXPECT_TRUE(handler.ExtractDoubleValue(&list, &value));
+  EXPECT_EQ(value, zero_value);
+  list.Clear();
+
+  list.Append(Value::CreateDoubleValue(neg_value));
+  EXPECT_TRUE(handler.ExtractDoubleValue(&list, &value));
+  EXPECT_EQ(value, neg_value);
+  list.Clear();
+
+  list.Append(Value::CreateDoubleValue(pos_value));
+  EXPECT_TRUE(handler.ExtractDoubleValue(&list, &value));
+  EXPECT_EQ(value, pos_value);
+}
+
+TEST(WebUIMessageHandlerTest, ExtractStringValue) {
+  TestWebUIMessageHandler handler;
+
+  ListValue list;
+  string16 in_string = "The facts, though interesting, are irrelevant."
+  list.Append(Value::CreateStringValue(string));
+  string16 out_string = handler.ExtractStringValue(&list);
+  EXPECT_STREQ(in_string.c_str(), out_string.c_str());
+}
+