diff options
| author | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-19 23:31:40 +0000 |
|---|---|---|
| committer | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-19 23:31:40 +0000 |
| commit | 1233aeda951f6cf2f9a332f12698b6b74ce94b94 (patch) | |
| tree | e4895d012aa05a0aa0abddc94741df20cc071d9a /content/browser | |
| parent | 26b8c69ed3352035c84e097a2f8cd7c2b44f93a2 (diff) | |
| download | chromium_src-1233aeda951f6cf2f9a332f12698b6b74ce94b94.zip chromium_src-1233aeda951f6cf2f9a332f12698b6b74ce94b94.tar.gz chromium_src-1233aeda951f6cf2f9a332f12698b6b74ce94b94.tar.bz2 | |
Revert 101858 - Broke content_unittests
Add a file thread to ResourceDispatcherHostTest.
During content_unittests:ResourceDispatcherHostTest.IgnoreCancelForDownloads, DownloadResourceHandler releases a DownloadBuffer and posts a task to the FILE thread so that DownloadFileManager can handle the buffer. If there's no FILE thread, the download doesn't complete processing and the DownloadBuffer is leaked.
BUG=Leak of DownloadBuffer during IgnoreCancelForDownloads test.
TEST=valgrind tests
Review URL: http://codereview.chromium.org/7941026
TBR=asanka@chromium.org
Review URL: http://codereview.chromium.org/7966006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101865 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser')
| -rw-r--r-- | content/browser/renderer_host/resource_dispatcher_host_unittest.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/content/browser/renderer_host/resource_dispatcher_host_unittest.cc b/content/browser/renderer_host/resource_dispatcher_host_unittest.cc index 7f9fa9a..8dfc1ad 100644 --- a/content/browser/renderer_host/resource_dispatcher_host_unittest.cc +++ b/content/browser/renderer_host/resource_dispatcher_host_unittest.cc @@ -258,7 +258,6 @@ class ResourceDispatcherHostTest : public testing::Test, public: ResourceDispatcherHostTest() : ui_thread_(BrowserThread::UI, &message_loop_), - file_thread_(BrowserThread::FILE, &message_loop_), io_thread_(BrowserThread::IO, &message_loop_), ALLOW_THIS_IN_INITIALIZER_LIST(filter_(new ForwardingFilter(this))), host_(ResourceQueue::DelegateSet()), @@ -387,7 +386,6 @@ class ResourceDispatcherHostTest : public testing::Test, MessageLoopForIO message_loop_; BrowserThread ui_thread_; - BrowserThread file_thread_; BrowserThread io_thread_; scoped_refptr<ForwardingFilter> filter_; ResourceDispatcherHost host_; |