diff options
| author | fukino <fukino@chromium.org> | 2016-01-25 22:14:49 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-26 06:15:49 +0000 |
| commit | 141a612f9d12ff9e5194dbba6d81d9d812f8ea7d (patch) | |
| tree | b04cdc60cf0a07f47810b92b8cf4899cb327770e /content/browser | |
| parent | 3983f64a3c99469d868ca1107a35336732c7dd6a (diff) | |
| download | chromium_src-141a612f9d12ff9e5194dbba6d81d9d812f8ea7d.zip chromium_src-141a612f9d12ff9e5194dbba6d81d9d812f8ea7d.tar.gz chromium_src-141a612f9d12ff9e5194dbba6d81d9d812f8ea7d.tar.bz2 | |
Run recursive file operations sequentially.
Parallel copy can have huge performance drop in some cases. (See issue 578923 for the detail)
For safety and simplicity, this CL makes the recursive file operations sequential.
BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.
Review URL: https://codereview.chromium.org/1619733004
Cr-Commit-Position: refs/heads/master@{#371467}
Diffstat (limited to 'content/browser')
| -rw-r--r-- | content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc b/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc index 055b8f2..6e2fcca 100644 --- a/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc +++ b/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc @@ -619,8 +619,10 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, ASSERT_TRUE(helper.DirectoryExists(src)); ASSERT_TRUE(helper.DirectoryExists(dest)); + // In the move operation, [file 0, file 2, file 3] are processed as LIFO. + // After file 3 is processed, file 2 is rejected by the validator and the + // operation fails. That is, only file 3 should be in dest. FileSystemTestCaseRecord kMoveDirResultCases[] = { - {false, FILE_PATH_LITERAL("file 0"), 38}, {false, FILE_PATH_LITERAL("file 3"), 0}, }; |