summaryrefslogtreecommitdiffstats
path: root/content/browser
diff options
context:
space:
mode:
authorDmitry Lomov <dslomov@chromium.org>2014-09-03 11:12:49 +0200
committerDmitry Lomov <dslomov@chromium.org>2014-09-03 09:18:29 +0000
commit483aa08bcdeeab74093dba94add5be020b7aa360 (patch)
treeee0b70bd5a2e5d070405576fcdbfe0f1fbfe8f7e /content/browser
parentc3cf6485f0845385c5d0a2acc1dba88709c0f373 (diff)
downloadchromium_src-483aa08bcdeeab74093dba94add5be020b7aa360.zip
chromium_src-483aa08bcdeeab74093dba94add5be020b7aa360.tar.gz
chromium_src-483aa08bcdeeab74093dba94add5be020b7aa360.tar.bz2
Revert "Adding more detailed UMA histogram for detection of output audio glitches."
This reverts commit 03573630c9619e21c299eef4fd41c8704421d2a6 for breaking Android build. TBR=henrika@chromium.org Review URL: https://codereview.chromium.org/538443002 Cr-Commit-Position: refs/heads/master@{#293102}
Diffstat (limited to 'content/browser')
-rw-r--r--content/browser/renderer_host/media/audio_sync_reader.cc32
1 files changed, 0 insertions, 32 deletions
diff --git a/content/browser/renderer_host/media/audio_sync_reader.cc b/content/browser/renderer_host/media/audio_sync_reader.cc
index 79613da..3daacca 100644
--- a/content/browser/renderer_host/media/audio_sync_reader.cc
+++ b/content/browser/renderer_host/media/audio_sync_reader.cc
@@ -9,32 +9,12 @@
#include "base/command_line.h"
#include "base/memory/shared_memory.h"
#include "base/metrics/histogram.h"
-#include "base/strings/stringprintf.h"
-#include "content/browser/renderer_host/media/media_stream_manager.h"
#include "content/public/common/content_switches.h"
#include "media/audio/audio_buffers_state.h"
#include "media/audio/audio_parameters.h"
using media::AudioBus;
-namespace {
-
-// Used to log if any audio glitches have been detected during an audio session.
-// Elements in this enum should not be added, deleted or rearranged.
-enum AudioGlitchResult {
- AUDIO_RENDERER_NO_AUDIO_GLITCHES = 0,
- AUDIO_RENDERER_AUDIO_GLITCHES = 1,
- AUDIO_RENDERER_AUDIO_GLITCHES_MAX = AUDIO_RENDERER_AUDIO_GLITCHES
-};
-
-void LogAudioGlitchResult(AudioGlitchResult result) {
- UMA_HISTOGRAM_ENUMERATION("Media.AudioRendererAudioGlitches",
- result,
- AUDIO_RENDERER_AUDIO_GLITCHES_MAX + 1);
-}
-
-} // namespace
-
namespace content {
AudioSyncReader::AudioSyncReader(base::SharedMemory* shared_memory,
@@ -67,18 +47,6 @@ AudioSyncReader::~AudioSyncReader() {
100.0 * renderer_missed_callback_count_ / renderer_callback_count_;
UMA_HISTOGRAM_PERCENTAGE(
"Media.AudioRendererMissedDeadline", percentage_missed);
-
- // Add more detailed information regarding detected audio glitches where
- // a non-zero value of |renderer_missed_callback_count_| is added to the
- // AUDIO_RENDERER_AUDIO_GLITCHES bin.
- renderer_missed_callback_count_ > 0 ?
- LogAudioGlitchResult(AUDIO_RENDERER_AUDIO_GLITCHES) :
- LogAudioGlitchResult(AUDIO_RENDERER_NO_AUDIO_GLITCHES);
- std::string log_string = base::StringPrintf(
- "ASR: number of detected audio glitches=%ld",
- renderer_missed_callback_count_);
- MediaStreamManager::SendMessageToNativeLog(log_string);
- DVLOG(1) << log_string;
}
// media::AudioOutputController::SyncReader implementations.