diff options
author | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-06 04:34:04 +0000 |
---|---|---|
committer | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-06 04:34:04 +0000 |
commit | c1c758e1e8837f248edf6a1d1c4fc60da1e00e04 (patch) | |
tree | 1721bd2c13f8b1362e406c5c37230632ef834131 /content/browser | |
parent | a1e60da8d42afdaa7eae9965c64cf0c6204434a7 (diff) | |
download | chromium_src-c1c758e1e8837f248edf6a1d1c4fc60da1e00e04.zip chromium_src-c1c758e1e8837f248edf6a1d1c4fc60da1e00e04.tar.gz chromium_src-c1c758e1e8837f248edf6a1d1c4fc60da1e00e04.tar.bz2 |
Revert 113015 - speculative revert to see if this fixes the interactive test breakage
Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used.
BUG=98716
Review URL: http://codereview.chromium.org/8801002
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8817007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113110 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser')
-rw-r--r-- | content/browser/renderer_host/render_view_host.cc | 8 | ||||
-rw-r--r-- | content/browser/renderer_host/render_view_host.h | 1 | ||||
-rw-r--r-- | content/browser/tab_contents/tab_contents.cc | 8 | ||||
-rw-r--r-- | content/browser/tab_contents/tab_contents.h | 1 |
4 files changed, 9 insertions, 9 deletions
diff --git a/content/browser/renderer_host/render_view_host.cc b/content/browser/renderer_host/render_view_host.cc index d177462..3b539a3 100644 --- a/content/browser/renderer_host/render_view_host.cc +++ b/content/browser/renderer_host/render_view_host.cc @@ -712,7 +712,6 @@ bool RenderViewHost::OnMessageReceived(const IPC::Message& msg) { IPC_MESSAGE_HANDLER(DragHostMsg_UpdateDragCursor, OnUpdateDragCursor) IPC_MESSAGE_HANDLER(DragHostMsg_TargetDrop_ACK, OnTargetDropACK) IPC_MESSAGE_HANDLER(ViewHostMsg_TakeFocus, OnTakeFocus) - IPC_MESSAGE_HANDLER(ViewHostMsg_FocusedNodeChanged, OnFocusedNodeChanged) IPC_MESSAGE_HANDLER(ViewHostMsg_AddMessageToConsole, OnAddMessageToConsole) IPC_MESSAGE_HANDLER(ViewHostMsg_ShouldClose_ACK, OnMsgShouldCloseACK) IPC_MESSAGE_HANDLER(ViewHostMsg_ClosePage_ACK, OnMsgClosePageACK) @@ -1132,13 +1131,6 @@ void RenderViewHost::OnTakeFocus(bool reverse) { view->TakeFocus(reverse); } -void RenderViewHost::OnFocusedNodeChanged(bool is_editable_node) { - content::NotificationService::current()->Notify( - content::NOTIFICATION_FOCUS_CHANGED_IN_PAGE, - content::Source<RenderViewHost>(this), - content::Details<const bool>(&is_editable_node)); -} - void RenderViewHost::OnAddMessageToConsole(int32 level, const string16& message, int32 line_no, diff --git a/content/browser/renderer_host/render_view_host.h b/content/browser/renderer_host/render_view_host.h index 99cc989..1375e67 100644 --- a/content/browser/renderer_host/render_view_host.h +++ b/content/browser/renderer_host/render_view_host.h @@ -564,7 +564,6 @@ class CONTENT_EXPORT RenderViewHost : public RenderWidgetHost { void OnUpdateDragCursor(WebKit::WebDragOperation drag_operation); void OnTargetDropACK(); void OnTakeFocus(bool reverse); - void OnFocusedNodeChanged(bool is_editable_node); void OnAddMessageToConsole(int32 level, const string16& message, int32 line_no, diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc index e716148..9176a5e 100644 --- a/content/browser/tab_contents/tab_contents.cc +++ b/content/browser/tab_contents/tab_contents.cc @@ -315,6 +315,7 @@ bool TabContents::OnMessageReceived(const IPC::Message& message) { OnUpdateContentRestrictions) IPC_MESSAGE_HANDLER(ViewHostMsg_GoToEntryAtOffset, OnGoToEntryAtOffset) IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateZoomLimits, OnUpdateZoomLimits) + IPC_MESSAGE_HANDLER(ViewHostMsg_FocusedNodeChanged, OnFocusedNodeChanged) IPC_MESSAGE_HANDLER(ViewHostMsg_SaveURLAs, OnSaveURL) IPC_MESSAGE_HANDLER(ViewHostMsg_EnumerateDirectory, OnEnumerateDirectory) IPC_MESSAGE_HANDLER(ViewHostMsg_JSOutOfMemory, OnJSOutOfMemory) @@ -1151,6 +1152,13 @@ void TabContents::OnUpdateZoomLimits(int minimum_percent, temporary_zoom_settings_ = !remember; } +void TabContents::OnFocusedNodeChanged(bool is_editable_node) { + content::NotificationService::current()->Notify( + content::NOTIFICATION_FOCUS_CHANGED_IN_PAGE, + content::Source<TabContents>(this), + content::Details<const bool>(&is_editable_node)); +} + void TabContents::OnEnumerateDirectory(int request_id, const FilePath& path) { delegate()->EnumerateDirectory(this, request_id, path); diff --git a/content/browser/tab_contents/tab_contents.h b/content/browser/tab_contents/tab_contents.h index 7fa48b9..78a6952 100644 --- a/content/browser/tab_contents/tab_contents.h +++ b/content/browser/tab_contents/tab_contents.h @@ -642,6 +642,7 @@ class CONTENT_EXPORT TabContents : public PageNavigator, void OnUpdateZoomLimits(int minimum_percent, int maximum_percent, bool remember); + void OnFocusedNodeChanged(bool is_editable_node); void OnEnumerateDirectory(int request_id, const FilePath& path); void OnJSOutOfMemory(); void OnRegisterProtocolHandler(const std::string& protocol, |