diff options
| author | changwan <changwan@chromium.org> | 2015-12-06 02:05:59 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-06 10:06:55 +0000 |
| commit | cbfdec91085fba9e23b865c0db6cac2577d3ae44 (patch) | |
| tree | 36dd1e97cbe81513de10c1624b7e88bb7e21e0f7 /content/common/browser_plugin/browser_plugin_messages.h | |
| parent | 72d02d77b1a589d5493787ec448ba0a2e23e76fa (diff) | |
| download | chromium_src-cbfdec91085fba9e23b865c0db6cac2577d3ae44.zip chromium_src-cbfdec91085fba9e23b865c0db6cac2577d3ae44.tar.gz chromium_src-cbfdec91085fba9e23b865c0db6cac2577d3ae44.tar.bz2 | |
Resume cursor blinking on closing context menu
Currently, we suspend cursor blinking on mouse press and resume it on mouse
release. However, in the case of launching a context menu, we show context
menu immediately on mouse right click press, and the following key events
are consumed on the context menu, so mouse release event does not happen.
Thus, cursor blinking does not get resumed after context menu gets
dismissed.
The rationale for keep suspending caret blinking while showing context
menu, I think, is that once context menu shows, key and mouse events will
be consumed on the context menu on linux. We keep that behavior, and
de-suspend caret blinking when context menu gets closed.
On Linux, we will resume caret blinking in
RenderFrameImpl::OnContextMenuClosed().
On Android, there are two different paths to show context menu:
- paste popup menu (long press on text, on chrome and webview)
- context menu (long press on link, only on chrome)
So we will call WebContents#onContextMenuClosed() from both paths.
BUG=554683
Review URL: https://codereview.chromium.org/1471993002
Cr-Commit-Position: refs/heads/master@{#363360}
Diffstat (limited to 'content/common/browser_plugin/browser_plugin_messages.h')
0 files changed, 0 insertions, 0 deletions