diff options
| author | fsamuel <fsamuel@chromium.org> | 2014-11-19 15:19:34 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-19 23:19:52 +0000 |
| commit | b45f55be7958e1a2dbd30261c10436b49829782d (patch) | |
| tree | 0841bc11ee05c8b751c8dea4e2bc55f088a87864 /content/common/browser_plugin | |
| parent | 0fe32d756a8b45e34273dafa94b9c184c17ef971 (diff) | |
| download | chromium_src-b45f55be7958e1a2dbd30261c10436b49829782d.zip chromium_src-b45f55be7958e1a2dbd30261c10436b49829782d.tar.gz chromium_src-b45f55be7958e1a2dbd30261c10436b49829782d.tar.bz2 | |
Browser Plugin: Simplify attachment logic
This CL is both code simplification and fixes a subtle bug.
Prior to this CL, we were dropping resizes between calls to BrowserPlugin::Attach
and BrowserPlugin::OnAttachACK. It seems AttachACK is now unnecessary (its functionality
was moved out of BrowserPlugin), and so we can simply get rid of it and the associated
attach_pending_ flag.
BUG=434827
TBR=kenrb@chromium.org for browser_plugin_messages.h IPC removal.
Review URL: https://codereview.chromium.org/736953005
Cr-Commit-Position: refs/heads/master@{#304919}
Diffstat (limited to 'content/common/browser_plugin')
| -rw-r--r-- | content/common/browser_plugin/browser_plugin_messages.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/content/common/browser_plugin/browser_plugin_messages.h b/content/common/browser_plugin/browser_plugin_messages.h index 61fbdef..57070855 100644 --- a/content/common/browser_plugin/browser_plugin_messages.h +++ b/content/common/browser_plugin/browser_plugin_messages.h @@ -162,11 +162,6 @@ IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_ResizeGuest, // ----------------------------------------------------------------------------- // These messages are from the browser process to the embedder. -// This message is sent in response to a completed attachment of a guest -// to a BrowserPlugin. -IPC_MESSAGE_CONTROL1(BrowserPluginMsg_Attach_ACK, - int /* browser_plugin_instance_id */) - // When the guest crashes, the browser process informs the embedder through this // message. IPC_MESSAGE_CONTROL1(BrowserPluginMsg_GuestGone, |