diff options
| author | wfh@chromium.org <wfh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 11:00:20 +0000 |
|---|---|---|
| committer | wfh@chromium.org <wfh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 11:00:20 +0000 |
| commit | a2b85426cb46dd9ad5ad1f06f6c2c4d61db696b7 (patch) | |
| tree | 99a675937c5683ff068925aaa48d004417747bb9 /content/common/child_process_host_impl.cc | |
| parent | f1cc2a960b39dc0c85856bf54c4bfd2217d2586f (diff) | |
| download | chromium_src-a2b85426cb46dd9ad5ad1f06f6c2c4d61db696b7.zip chromium_src-a2b85426cb46dd9ad5ad1f06f6c2c4d61db696b7.tar.gz chromium_src-a2b85426cb46dd9ad5ad1f06f6c2c4d61db696b7.tar.bz2 | |
Remove PROCESS_DUP_HANDLE from OpenProcessHandle since PROCESS_DUP_HANDLE access is pretty much the same as
PROCESS_ALL_ACCESS
http://msdn.microsoft.com/en-us/library/ms684880(v=vs.85).aspx
Change valid callers to OpenProcessHandle to call
OpenPrivilegedProcessHandle instead
also fix small handle leak in
ChromeFrameMemoryTest::GetMemoryConsumptionDetails
A separate bug will be raised to go through all
calls to OpenPrivilegedProcessHandle and examine
whether they actually need this level of access and if not
change call to OpenProcessHandleWithAccess with minimum rights
needed to perform the operations
BUG=226430
TBR=grt, yoshiki, jar
Review URL: https://chromiumcodereview.appspot.com/13598009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193080 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/common/child_process_host_impl.cc')
| -rw-r--r-- | content/common/child_process_host_impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/common/child_process_host_impl.cc b/content/common/child_process_host_impl.cc index 606811d..b5d1eda 100644 --- a/content/common/child_process_host_impl.cc +++ b/content/common/child_process_host_impl.cc @@ -262,7 +262,7 @@ bool ChildProcessHostImpl::OnMessageReceived(const IPC::Message& msg) { } void ChildProcessHostImpl::OnChannelConnected(int32 peer_pid) { - if (!base::OpenProcessHandle(peer_pid, &peer_handle_)) { + if (!base::OpenPrivilegedProcessHandle(peer_pid, &peer_handle_)) { NOTREACHED(); } opening_channel_ = false; |