summaryrefslogtreecommitdiffstats
path: root/content/common/sandbox_linux
diff options
context:
space:
mode:
authorpcc <pcc@chromium.org>2015-08-04 17:46:39 -0700
committerCommit bot <commit-bot@chromium.org>2015-08-05 00:47:56 +0000
commited9ea9af2cf1ab10d0e5ecaaa008b19fe980a4aa (patch)
tree9c2bb672074207e05303c9e8da9e1162547af0f5 /content/common/sandbox_linux
parentd7d0894bef96ad7349d4089a0dc3a16c3b9c5e9f (diff)
downloadchromium_src-ed9ea9af2cf1ab10d0e5ecaaa008b19fe980a4aa.zip
chromium_src-ed9ea9af2cf1ab10d0e5ecaaa008b19fe980a4aa.tar.gz
chromium_src-ed9ea9af2cf1ab10d0e5ecaaa008b19fe980a4aa.tar.bz2
CFI: Enable stack traces in renderer process in non-official CFI builds.
A CFI failure causes a SIGILL signal to be raised, and the most likely place for a failure to occur is in the renderer. By printing a stack trace we provide developers with a basic set of information about CFI failures, and allow crashes to be disambiguated by ClusterFuzz. BUG=464797 R=jln@chromium.org,jam@chromium.org Review URL: https://codereview.chromium.org/1269673003 Cr-Commit-Position: refs/heads/master@{#341833}
Diffstat (limited to 'content/common/sandbox_linux')
-rw-r--r--content/common/sandbox_linux/sandbox_linux.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/content/common/sandbox_linux/sandbox_linux.cc b/content/common/sandbox_linux/sandbox_linux.cc
index b2a7b3e..952772e 100644
--- a/content/common/sandbox_linux/sandbox_linux.cc
+++ b/content/common/sandbox_linux/sandbox_linux.cc
@@ -140,7 +140,7 @@ void LinuxSandbox::PreinitializeSandbox() {
sanitizer_args_.reset();
#endif
-#if !defined(NDEBUG)
+#if !defined(NDEBUG) || (defined(CFI_ENFORCEMENT) && !defined(OFFICIAL_BUILD))
// The in-process stack dumping needs to open /proc/self/maps and cache
// its contents before the sandbox is enabled. It also pre-opens the
// object files that are already loaded in the process address space.