Change the WebResourceService to use SystemURLRequestContext, and fix leak that this change exposes, by ensuring that the SystemURLRequestContextGetter is deleted immediately once it is no longer needed.

BUG=86168
TEST=browser_tests complete on all bots with no leak_tracker firings.
Review URL: http://codereview.chromium.org/7044118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90799 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 9 deletions

diff --git a/content/common/url_fetcher.h b/content/common/url_fetcher.h
index 64aa3ea..0eaa7c7 100644
--- a/content/common/url_fetcher.h
+++ b/content/common/url_fetcher.h
@@ -187,9 +187,9 @@ class URLFetcher {
   // after backoff_delay() elapses. URLFetcher has it set to true by default.
   void set_automatically_retry_on_5xx(bool retry);
 
-  int max_retries() const { return max_retries_; }
+  int max_retries() const;
 
-  void set_max_retries(int max_retries) { max_retries_ = max_retries; }
+  void set_max_retries(int max_retries);
 
   // Returns the back-off delay before the request will be retried,
   // when a 5xx response was received.
@@ -226,6 +226,10 @@ class URLFetcher {
   // settings.
   virtual void Start();
 
+  // Restarts the URLFetcher with a new URLRequestContextGetter.
+  void StartWithRequestContextGetter(
+      net::URLRequestContextGetter* request_context_getter);
+
   // Return the URL that this fetcher is processing.
   virtual const GURL& url() const;
 
@@ -302,15 +306,8 @@ class URLFetcher {
 
   static Factory* factory_;
 
-  // If |automatically_retry_on_5xx_| is false, 5xx responses will be
-  // propagated to the observer, if it is true URLFetcher will automatically
-  // re-execute the request, after the back-off delay has expired.
-  // true by default.
-  bool automatically_retry_on_5xx_;
   // Back-off time delay. 0 by default.
   base::TimeDelta backoff_delay_;
-  // Maximum retries allowed.
-  int max_retries_;
 
   static bool g_interception_enabled;