diff options
| author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 08:47:13 +0000 |
|---|---|---|
| committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 08:47:13 +0000 |
| commit | 60d6cca71d7aeed69b5f11abe1273063b94d6d13 (patch) | |
| tree | 15dea83cc3383461dfbb386cefb7e4dcc3da7378 /content/common/view_messages.h | |
| parent | dfe1bef94ad69bb3f04e674629f40bf8a6b9cbba (diff) | |
| download | chromium_src-60d6cca71d7aeed69b5f11abe1273063b94d6d13.zip chromium_src-60d6cca71d7aeed69b5f11abe1273063b94d6d13.tar.gz chromium_src-60d6cca71d7aeed69b5f11abe1273063b94d6d13.tar.bz2 | |
Switch content_shell from using PruneAllButActive to a more explicit approach
During layout tests, we want to reuse one WebContents for running multiple
layout tests. Since layout tests assume that they're the first entry in the
session history, we need to reset the session history.
DumpRenderTree achieved this by just killing the NavigationController. Since
that's not possible in the content module, I used the instant api
PruneAllButActive. This API, however, depends on the currently active RenderView
being the last in the session history, which is almost impossible to guarantee
in practice.
Instead, I added a flag to LoadURLParams that instructs the NavigationController
to reset itself as soon as the navigation to the next test commits.
BUG=111316
TEST=the fast/history tests don't fail flakily
TBR=creis@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/14134003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197314 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/common/view_messages.h')
| -rw-r--r-- | content/common/view_messages.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/content/common/view_messages.h b/content/common/view_messages.h index 575d481..adc35cf 100644 --- a/content/common/view_messages.h +++ b/content/common/view_messages.h @@ -421,6 +421,10 @@ IPC_STRUCT_BEGIN_WITH_PARENT(ViewHostMsg_FrameNavigate_Params, // User agent override used to navigate. IPC_STRUCT_MEMBER(bool, is_overriding_user_agent) + + // Notifies the browser that for this navigation, the session history was + // successfully cleared. + IPC_STRUCT_MEMBER(bool, history_list_was_cleared) IPC_STRUCT_END() IPC_STRUCT_BEGIN(ViewHostMsg_OpenURL_Params) @@ -572,6 +576,11 @@ IPC_STRUCT_BEGIN(ViewMsg_Navigate_Params) IPC_STRUCT_MEMBER(int, current_history_list_offset) IPC_STRUCT_MEMBER(int, current_history_list_length) + // Informs the RenderView the session history should be cleared. In that + // case, the RenderView needs to notify the browser that the clearing was + // succesful when the navigation commits. + IPC_STRUCT_MEMBER(bool, should_clear_history_list) + // The URL to load. IPC_STRUCT_MEMBER(GURL, url) |