diff options
| author | jam <jam@chromium.org> | 2016-02-29 22:36:36 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-01 06:37:54 +0000 |
| commit | 284d12c2bb76b632ee7e3e43f76e33f64adfa0ee (patch) | |
| tree | 1f6891c0466e777c5deac194e2410c881c03d325 /content/content_app.gypi | |
| parent | c58de7ec4cdbb412e7c03a57b9beef6d369bca60 (diff) | |
| download | chromium_src-284d12c2bb76b632ee7e3e43f76e33f64adfa0ee.zip chromium_src-284d12c2bb76b632ee7e3e43f76e33f64adfa0ee.tar.gz chromium_src-284d12c2bb76b632ee7e3e43f76e33f64adfa0ee.tar.bz2 | |
Fix missing dependency on Android gyp builds with mojo.
I hit this when building locally to reproduce another build error:
In file included from ../../content/browser/frame_host/frame_tree_node.h:16:0,
from ../../content/test/content_browser_test_utils_internal.cc:22:
../../content/browser/frame_host/render_frame_host_impl.h:34:68: fatal error: content/common/image_downloader/image_downloader.mojom.h: No such file or directory
#include "content/common/image_downloader/image_downloader.mojom.h"
The problem is that content_browser_test_support target, which depends includes content_browser_test_utils_internal.cc, doesn't depend on content_browser on Android. It instead depends on content_app_both. content_app.gypi only had a direct dependency on the bindings, but needs an export dependency as well.
Review URL: https://codereview.chromium.org/1750823002
Cr-Commit-Position: refs/heads/master@{#378407}
Diffstat (limited to 'content/content_app.gypi')
| -rw-r--r-- | content/content_app.gypi | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/content/content_app.gypi b/content/content_app.gypi index e93f550..7f64025 100644 --- a/content/content_app.gypi +++ b/content/content_app.gypi @@ -17,6 +17,9 @@ '../ui/gfx/gfx.gyp:gfx_geometry', 'content_common_mojo_bindings.gyp:content_common_mojo_bindings', ], + 'export_dependent_settings': [ + 'content_common_mojo_bindings.gyp:content_common_mojo_bindings', + ], 'sources': [ 'app/android/app_jni_registrar.cc', 'app/android/app_jni_registrar.h', |