diff options
| author | ben <ben@chromium.org> | 2015-11-15 04:13:09 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-15 12:14:44 +0000 |
| commit | 03b7b9d5d01d4b23362a1b9fcd13900fbb11286c (patch) | |
| tree | 71181e958a9510ce5aa9de3e00c5b9e96b5ca410 /content/content_common.gypi | |
| parent | e9b72dd87754ca5a4af39509070ae682c5e5bc14 (diff) | |
| download | chromium_src-03b7b9d5d01d4b23362a1b9fcd13900fbb11286c.zip chromium_src-03b7b9d5d01d4b23362a1b9fcd13900fbb11286c.tar.gz chromium_src-03b7b9d5d01d4b23362a1b9fcd13900fbb11286c.tar.bz2 | |
Move Shell connection to content.
I want to be able to use Mojo in content, so I think it makes sense that the shell bind step lives in content too.
1. Moves MojoRunnerState to content/common and renames it to MojoShellConnection. This class will be available in any process that creates an impl prior to running the main message loop.
2. Modifies ChildProcessLauncher to create a platform channel pair and put the client handle on the command line of the child process, and registers the server handle with the external shell. This will allow the child process to bind an Application request if it wants.
TODO: What if the child process doesn't bind it? What happens to the instance created in the external shell?
TODO: ChildProcessLauncher is a convenient chokepoint. It means the shell handle is passed to all child processes created by content. Do we want to do this? I think it's OK for now since this code is only triggered if Chrome itself is run from within the external shell. Before we can move this to production I think CreateInstanceForHandle is going to have to take a CapabilityFilter.
R=jam@chromium.org
http://crbug.com/551253
Review URL: https://codereview.chromium.org/1442893002
Cr-Commit-Position: refs/heads/master@{#359770}
Diffstat (limited to 'content/content_common.gypi')
| -rw-r--r-- | content/content_common.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/content/content_common.gypi b/content/content_common.gypi index f9236da..7a04d5e 100644 --- a/content/content_common.gypi +++ b/content/content_common.gypi @@ -91,6 +91,7 @@ 'public/common/message_port_types.h', 'public/common/mojo_channel_switches.cc', 'public/common/mojo_channel_switches.h', + 'public/common/mojo_shell_connection.h', 'public/common/navigator_connect_client.cc', 'public/common/navigator_connect_client.h', 'public/common/origin_util.h', |