diff options
| author | jam <jam@chromium.org> | 2015-08-13 11:30:21 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-13 18:31:03 +0000 |
| commit | 8ba532e170befc312e66d032587fa2ad04bac975 (patch) | |
| tree | 5804cef67958f109ab4d0bc4781a8656126b4ea2 /content/gpu | |
| parent | c040432a33591da9dcaf2cabf391893353f0107a (diff) | |
| download | chromium_src-8ba532e170befc312e66d032587fa2ad04bac975.zip chromium_src-8ba532e170befc312e66d032587fa2ad04bac975.tar.gz chromium_src-8ba532e170befc312e66d032587fa2ad04bac975.tar.bz2 | |
Print stack traces in child processes when browser tests failed.
The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds.
BUG=517488,358267
Review URL: https://codereview.chromium.org/1291553003
Cr-Commit-Position: refs/heads/master@{#343240}
Diffstat (limited to 'content/gpu')
| -rw-r--r-- | content/gpu/gpu_main.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/content/gpu/gpu_main.cc b/content/gpu/gpu_main.cc index 7820638..8606afe 100644 --- a/content/gpu/gpu_main.cc +++ b/content/gpu/gpu_main.cc @@ -540,13 +540,6 @@ bool StartSandboxWindows(const sandbox::SandboxInterfaceInfo* sandbox_info) { // content. sandbox::TargetServices* target_services = sandbox_info->target_services; if (target_services) { -#if defined(ADDRESS_SANITIZER) - // Bind and leak dbghelp.dll before the token is lowered, otherwise - // AddressSanitizer will crash when trying to symbolize a report. - if (!LoadLibraryA("dbghelp.dll")) - return false; -#endif - target_services->LowerToken(); return true; } |