diff options
| author | rockot <rockot@chromium.org> | 2015-08-16 10:36:43 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-16 17:37:25 +0000 |
| commit | 531d19bbe954ecd92d2027d2c4d0d6c850cfe0de (patch) | |
| tree | a2befaa0937d12b8be4af8cfbc0609e23a53a7db /content/ppapi_plugin | |
| parent | d7996e64b1d86fa874e1f9b98563dedd5d4e3af5 (diff) | |
| download | chromium_src-531d19bbe954ecd92d2027d2c4d0d6c850cfe0de.zip chromium_src-531d19bbe954ecd92d2027d2c4d0d6c850cfe0de.tar.gz chromium_src-531d19bbe954ecd92d2027d2c4d0d6c850cfe0de.tar.bz2 | |
Revert of Print stack traces in child processes when browser tests failed. (patchset #5 id:80001 of https://codereview.chromium.org/1291553003/ )
Reason for revert:
This is unfortunately breaking Windows 10 in a major way. I did a local bisect and narrowed it down to this CL.
BUG=521242
Original issue's description:
> Print stack traces in child processes when browser tests failed.
>
> The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds.
>
> BUG=517488,358267
>
> Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975
> Cr-Commit-Position: refs/heads/master@{#343240}
TBR=scottmg@chromium.org,jln@chromium.org,wfh@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517488,358267
Review URL: https://codereview.chromium.org/1299583002
Cr-Commit-Position: refs/heads/master@{#343603}
Diffstat (limited to 'content/ppapi_plugin')
| -rw-r--r-- | content/ppapi_plugin/ppapi_thread.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc index 6b2dc12..d220244 100644 --- a/content/ppapi_plugin/ppapi_thread.cc +++ b/content/ppapi_plugin/ppapi_thread.cc @@ -404,6 +404,12 @@ void PpapiThread::OnLoadPlugin(const base::FilePath& path, WarmupWindowsLocales(permissions); +#if defined(ADDRESS_SANITIZER) + // Bind and leak dbghelp.dll before the token is lowered, otherwise + // AddressSanitizer will crash when trying to symbolize a report. + LoadLibraryA("dbghelp.dll"); +#endif + g_target_services->LowerToken(); } #endif |