diff options
| author | scottmg <scottmg@chromium.org> | 2015-11-25 18:27:49 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-26 02:28:34 +0000 |
| commit | e3d37e4b4a5683225ee5e2fa427a7129d64fce18 (patch) | |
| tree | 0f620dfa25d55f65567c4b9f4ad137b4801deb30 /content/ppapi_plugin | |
| parent | f170638b5c333ef8220ff6ee7836efef7452ebd3 (diff) | |
| download | chromium_src-e3d37e4b4a5683225ee5e2fa427a7129d64fce18.zip chromium_src-e3d37e4b4a5683225ee5e2fa427a7129d64fce18.tar.gz chromium_src-e3d37e4b4a5683225ee5e2fa427a7129d64fce18.tar.bz2 | |
Revert of Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (patchset #48 id:1160001 of https://codereview.chromium.org/1416133003/ )
Reason for revert:
Some failing tests https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/43485. Unclear why they didn't fail on trybots so I'm going to revert and investigate.
Original issue's description:
> Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
>
> Crashpad is always compiled into chrome and its handler is always
> enabled. It only uploads in Official builds.
>
> On Windows, the crash handler is chrome.exe run with a
> --crashpad-handler argument. This is due to concern about
> incompatibilities of shipping an additional new different binary for AV,
> firewalls, etc.
>
> Sample renderer crash/1aed2bc785e28995
> Sample browser: crash/66c822815474a5d8
>
> See also http://crbug.com/427611 .
>
> R=mark@chromium.org,cpu@chromium.org
> BUG=447073,546288, 456193
>
> Committed: https://crrev.com/aaa2ff656f9fcabcbdd9e9964e3b2bdc8f5102ed
> Cr-Commit-Position: refs/heads/master@{#361742}
TBR=mark@chromium.org,cpu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447073,546288, 456193
Review URL: https://codereview.chromium.org/1476193002
Cr-Commit-Position: refs/heads/master@{#361797}
Diffstat (limited to 'content/ppapi_plugin')
| -rw-r--r-- | content/ppapi_plugin/ppapi_plugin_main.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/content/ppapi_plugin/ppapi_plugin_main.cc b/content/ppapi_plugin/ppapi_plugin_main.cc index 52f87a5..497e195 100644 --- a/content/ppapi_plugin/ppapi_plugin_main.cc +++ b/content/ppapi_plugin/ppapi_plugin_main.cc @@ -4,7 +4,6 @@ #include "base/base_paths.h" #include "base/command_line.h" -#include "base/debug/crash_logging.h" #include "base/debug/debugger.h" #include "base/files/file_path.h" #include "base/i18n/rtl.h" |