diff options
| author | qinmin <qinmin@chromium.org> | 2016-03-25 21:13:38 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-26 04:14:58 +0000 |
| commit | 30ac0f57a0fcae1a13e6374c05927a04caf526e5 (patch) | |
| tree | bb56349228c53a3ee588e25971e935af6996f5fb /content/public/browser/android/download_controller_android.h | |
| parent | 220c7edc3243b54970a13d91c690b2dffc15732d (diff) | |
| download | chromium_src-30ac0f57a0fcae1a13e6374c05927a04caf526e5.zip chromium_src-30ac0f57a0fcae1a13e6374c05927a04caf526e5.tar.gz chromium_src-30ac0f57a0fcae1a13e6374c05927a04caf526e5.tar.bz2 | |
Switch to use download GUID to indentify download items
Download GUID is introduced by
http://crrev.com/eef62b0282ec19ebc040785d0b7ac36de398cbc1
Unlike download Id, the GUID can live across browser sessions and will
not be reused.
This change switches the java class to also use the
GUID.
Chrome will temporarily use the old download Id as the notification Id.
This is because the android notification requires an int to identify it,
rather than a string.
In the future, we will generate the notification Id from java side.
The download Ids generated by the Android DownloadManager are not
affected by this CL.
However, they are only used in OMA downloads and when we call
addCompletedDownload().
BUG=593020
Review URL: https://codereview.chromium.org/1809203006
Cr-Commit-Position: refs/heads/master@{#383443}
Diffstat (limited to 'content/public/browser/android/download_controller_android.h')
| -rw-r--r-- | content/public/browser/android/download_controller_android.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/content/public/browser/android/download_controller_android.h b/content/public/browser/android/download_controller_android.h index e048afd..2ef664e 100644 --- a/content/public/browser/android/download_controller_android.h +++ b/content/public/browser/android/download_controller_android.h @@ -41,8 +41,9 @@ class CONTENT_EXPORT DownloadControllerAndroid : public DownloadItem::Observer { bool is_link, const std::string& extra_headers) = 0; // Called when a dangerous download item is verified or rejected. - virtual void DangerousDownloadValidated( - WebContents* web_contents, int download_id, bool accept) = 0; + virtual void DangerousDownloadValidated(WebContents* web_contents, + const std::string& download_guid, + bool accept) = 0; // Callback when user permission prompt finishes. Args: whether file access // permission is acquired. |