diff options
| author | dmazzoni@google.com <dmazzoni@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-07 05:26:46 +0000 |
|---|---|---|
| committer | dmazzoni@google.com <dmazzoni@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-07 05:26:46 +0000 |
| commit | 39f10bd4728af6571bc1ac72e53ea5ff584c3d93 (patch) | |
| tree | 5e18a90d0825a2f4afb251ff20795c6bc8c6e6aa /content/public/renderer/v8_value_converter.h | |
| parent | 33011ae92c7774a4e5c252a8721b8f5338dc2567 (diff) | |
| download | chromium_src-39f10bd4728af6571bc1ac72e53ea5ff584c3d93.zip chromium_src-39f10bd4728af6571bc1ac72e53ea5ff584c3d93.tar.gz chromium_src-39f10bd4728af6571bc1ac72e53ea5ff584c3d93.tar.bz2 | |
Revert 135602 - Allow serialization of ArrayBuffer params in extension/apps API methods
Caused these three tests to time out - apparently only in debug mode, which
is perhaps why they were not caught by try runs:
INCOMPLETE (5): TtsApiTest.RegisterEngine
INCOMPLETE (6): TtsApiTest.EngineError
INCOMPLETE (7): TtsApiTest.EngineWordCallbacks
Original description:
This changes the V8ValueConverter to do ArrayBuffer<->BinaryValue conversions,
as well as supporting ArrayBufferView subclasses as request parameters (but
not response ones, since that's unnecessary).
Also adds an experimental API for testing ArrayBuffers in request/response
parameters.
This depends on WebKit changes in https://bugs.webkit.org/show_bug.cgi?id=84899
BUG=122675
TEST=Included browser tests should pass
Review URL: http://codereview.chromium.org/10161038
TBR=asargent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135618 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/renderer/v8_value_converter.h')
| -rw-r--r-- | content/public/renderer/v8_value_converter.h | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/content/public/renderer/v8_value_converter.h b/content/public/renderer/v8_value_converter.h index 6e785c1..e8fad2a 100644 --- a/content/public/renderer/v8_value_converter.h +++ b/content/public/renderer/v8_value_converter.h @@ -1,4 +1,4 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -18,10 +18,8 @@ namespace content { // values (from base/values.h). Lists and dictionaries are converted // recursively. // -// The JSON types (null, boolean, string, number, array, and object) as well as -// binary values are supported. For binary values, we convert to WebKit -// ArrayBuffers, and support converting from an ArrayBuffer or any of the -// ArrayBufferView subclasses (Uint8Array, etc.). +// Only the JSON types (null, boolean, string, number, array, and object) are +// supported. class CONTENT_EXPORT V8ValueConverter { public: static V8ValueConverter* create(); |