diff options
| author | alancutter <alancutter@chromium.org> | 2015-11-18 15:54:20 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-18 23:55:18 +0000 |
| commit | 1b3bd8ec1752e2c0442746c0f1f60e693601b4f2 (patch) | |
| tree | ce03b66b71b9d344e2d67da7ed5ffefa19836b88 /content/public/renderer | |
| parent | c9a2c739d2bc6d1ce7e8a01f55ecd47a89593f24 (diff) | |
| download | chromium_src-1b3bd8ec1752e2c0442746c0f1f60e693601b4f2.zip chromium_src-1b3bd8ec1752e2c0442746c0f1f60e693601b4f2.tar.gz chromium_src-1b3bd8ec1752e2c0442746c0f1f60e693601b4f2.tar.bz2 | |
Revert of Bind Application in renderer (patchset #15 id:280001 of https://codereview.chromium.org/1452823003/ )
Reason for revert:
This change is making hundreds of webkit_tests crash on linux_chromium_rel_ng with:
[1:1:1118/141621:108326049405:FATAL:lock.cc(32)] Check failed: owning_thread_ref_.is_null().
#0 0x00000067e2de base::debug::StackTrace::StackTrace()
#1 0x00000057a71f logging::LogMessage::~LogMessage()
#2 0x0000005eb69b base::Lock::CheckUnheldAndMark()
#3 0x000000518e1c base::Lock::Acquire()
#4 0x000000518b43 base::AutoLock::AutoLock()
#5 0x0000005b4014 base::SequenceCheckerImpl::CalledOnValidSequencedThread()
#6 0x000006f074ae IDMap<>::Lookup()
#7 0x000006f0598c content::RendererBlinkPlatformImpl::SetPlatformEventObserverForTesting()
#8 0x000008459264 content::SetMockGamepadProvider()
Original issue's description:
> Bind Application in renderer.
>
> This involved changing how we get the client handle to the renderer. In the first iteration I was passing this on the command line but that turns out not to work with the sandbox. So instead I an approach used by the Mojo-in-Chrome MojoApplication class and pass the primordial handle via Chrome IPC.
>
> I had to twiddle a bunch of BUILD.gn files in content to get this to work without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.
>
> R=jam@chromium.org,tsepez@chromium.org
> http://crbug.com/551253
>
> Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
> Cr-Commit-Position: refs/heads/master@{#360293}
>
> Committed: https://crrev.com/2c716f9d5ebff610641f4506c17ec81d4b89b7bb
> Cr-Commit-Position: refs/heads/master@{#360396}
TBR=jam@chromium.org,tsepez@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1457173002
Cr-Commit-Position: refs/heads/master@{#360446}
Diffstat (limited to 'content/public/renderer')
| -rw-r--r-- | content/public/renderer/BUILD.gn | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/content/public/renderer/BUILD.gn b/content/public/renderer/BUILD.gn index 778d66f..0ab2d33 100644 --- a/content/public/renderer/BUILD.gn +++ b/content/public/renderer/BUILD.gn @@ -25,10 +25,7 @@ source_set("renderer_sources") { ".", "//content") - configs += [ - "//content:content_implementation", - "//content/public/common:mojo_shell_client", - ] + configs += [ "//content:content_implementation" ] deps = [ "//content/public/common:common_sources", |