diff options
author | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-04 07:09:21 +0000 |
---|---|---|
committer | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-04 07:09:21 +0000 |
commit | 97880c8bbb79a14eff349d8a128ccea48d6c4314 (patch) | |
tree | 1f62918f77fd9be58d0a9174f0a09094ea5678c4 /content/public/test/mock_render_thread.h | |
parent | 6cea1821712e08df4dc9d5e0a31cdce8187b121b (diff) | |
download | chromium_src-97880c8bbb79a14eff349d8a128ccea48d6c4314.zip chromium_src-97880c8bbb79a14eff349d8a128ccea48d6c4314.tar.gz chromium_src-97880c8bbb79a14eff349d8a128ccea48d6c4314.tar.bz2 |
Use UserMetricsAction for renderer user metrics.
Benefits of this change:
- Unified action recording. We don't need special renderer treatment in
extract_actions.py.
- UserMetricsAction() is shorter than RenderThread::Get()->RecordAction(). So
that we can have longer action names (since the action name must be on the
same line and we have 80 chars limit).
- Rename RecordUserMetrics() to RecordAction() to be consistent.
- Separate RecordComputedAction() from RecordAction() so that we can catch
unhandled computed actions.
TBR=bauerb@chromium.org
R=isherman@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/102073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238621 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/test/mock_render_thread.h')
-rw-r--r-- | content/public/test/mock_render_thread.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/content/public/test/mock_render_thread.h b/content/public/test/mock_render_thread.h index dc5b82a..fd3f58a 100644 --- a/content/public/test/mock_render_thread.h +++ b/content/public/test/mock_render_thread.h @@ -58,7 +58,8 @@ class MockRenderThread : public RenderThread { virtual void WidgetHidden() OVERRIDE; virtual void WidgetRestored() OVERRIDE; virtual void EnsureWebKitInitialized() OVERRIDE; - virtual void RecordUserMetrics(const std::string& action) OVERRIDE; + virtual void RecordAction(const UserMetricsAction& action) OVERRIDE; + virtual void RecordComputedAction(const std::string& action) OVERRIDE; virtual scoped_ptr<base::SharedMemory> HostAllocateSharedMemoryBuffer( size_t buffer_size) OVERRIDE; virtual void RegisterExtension(v8::Extension* extension) OVERRIDE; |