diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-08 17:24:26 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-08 17:24:26 +0000 |
| commit | 2769d081b047b46f5a67de487050ccf30135abd8 (patch) | |
| tree | 024690a0b2c0c801c51f1cacee9b4093a2d4d4a7 /content/public | |
| parent | ac0db3ff10d2aa6973ffe049e94941800658349c (diff) | |
| download | chromium_src-2769d081b047b46f5a67de487050ccf30135abd8.zip chromium_src-2769d081b047b46f5a67de487050ccf30135abd8.tar.gz chromium_src-2769d081b047b46f5a67de487050ccf30135abd8.tar.bz2 | |
Fix a crash when downloading invalid client certificates.
Additionally, remove some outdated comments/TODOs that no longer apply.
BUG=112451
Review URL: http://codereview.chromium.org/9361007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120991 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public')
| -rw-r--r-- | content/public/browser/content_browser_client.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h index 3c2fe1a..6f9dc71 100644 --- a/content/public/browser/content_browser_client.h +++ b/content/public/browser/content_browser_client.h @@ -233,9 +233,10 @@ class ContentBrowserClient { int render_view_id, SSLClientAuthHandler* handler) = 0; - // Adds a newly-generated client cert. The embedder should ensure that there's + // Adds a downloaded client cert. The embedder should ensure that there's // a private key for the cert, displays the cert to the user, and adds it upon - // user approval. + // user approval. If the downloaded data could not be interpreted as a valid + // certificate, |cert| will be NULL. virtual void AddNewCertificate( net::URLRequest* request, net::X509Certificate* cert, |