summaryrefslogtreecommitdiffstats
path: root/content/public
diff options
context:
space:
mode:
authorjam <jam@chromium.org>2016-03-22 22:34:24 -0700
committerCommit bot <commit-bot@chromium.org>2016-03-23 05:35:38 +0000
commit75c4422d8fdabd231f40a6c9235f4512f0170268 (patch)
tree95d8a4b3b54dc0ff1e22ad25e0fefcc7afb7d832 /content/public
parentb746ad977e2ad04e17a0792bd313f6e9d7a4be74 (diff)
downloadchromium_src-75c4422d8fdabd231f40a6c9235f4512f0170268.zip
chromium_src-75c4422d8fdabd231f40a6c9235f4512f0170268.tar.gz
chromium_src-75c4422d8fdabd231f40a6c9235f4512f0170268.tar.bz2
Remove logic for lazy initialization of WebKit.
See "Extensions impact on startup?" thread on (internal) chrome-fast mailing list from 8/14/2015 for background, which showed that effectively undoing this logic showed a 3% reduction on first_non_empty_paint_time. This lazy initialization used to be a performance win when it was added years ago, but has since become a performance drag. Since it's effectively not used now (since ChromeContentRendererClient::RenderThreadStarted always initializes WebKit through its call to RenderThread::RegisterExtension), just remove this unused logic. Review URL: https://codereview.chromium.org/1821413003 Cr-Commit-Position: refs/heads/master@{#382795}
Diffstat (limited to 'content/public')
-rw-r--r--content/public/renderer/render_process_observer.h3
-rw-r--r--content/public/renderer/render_thread.h4
-rw-r--r--content/public/test/mock_render_thread.cc3
-rw-r--r--content/public/test/mock_render_thread.h1
4 files changed, 0 insertions, 11 deletions
diff --git a/content/public/renderer/render_process_observer.h b/content/public/renderer/render_process_observer.h
index f53ba65..30f855d 100644
--- a/content/public/renderer/render_process_observer.h
+++ b/content/public/renderer/render_process_observer.h
@@ -27,9 +27,6 @@ class CONTENT_EXPORT RenderProcessObserver {
// Notification that the render process is shutting down.
virtual void OnRenderProcessShutdown() {}
- // Called right after the WebKit API is initialized.
- virtual void WebKitInitialized() {}
-
// Called when the renderer cache of the plugin list has changed.
virtual void PluginListChanged() {}
diff --git a/content/public/renderer/render_thread.h b/content/public/renderer/render_thread.h
index db554c1..7f88da9 100644
--- a/content/public/renderer/render_thread.h
+++ b/content/public/renderer/render_thread.h
@@ -75,10 +75,6 @@ class CONTENT_EXPORT RenderThread : virtual public ChildThread {
virtual void SetResourceDispatcherDelegate(
ResourceDispatcherDelegate* delegate) = 0;
- // We initialize WebKit as late as possible. Call this to force
- // initialization.
- virtual void EnsureWebKitInitialized() = 0;
-
// Asks the host to create a block of shared memory for the renderer.
// The shared memory allocated by the host is returned back.
virtual scoped_ptr<base::SharedMemory> HostAllocateSharedMemoryBuffer(
diff --git a/content/public/test/mock_render_thread.cc b/content/public/test/mock_render_thread.cc
index 55b2269..0160c43 100644
--- a/content/public/test/mock_render_thread.cc
+++ b/content/public/test/mock_render_thread.cc
@@ -123,9 +123,6 @@ void MockRenderThread::SetResourceDispatcherDelegate(
ResourceDispatcherDelegate* delegate) {
}
-void MockRenderThread::EnsureWebKitInitialized() {
-}
-
void MockRenderThread::RecordAction(const base::UserMetricsAction& action) {
}
diff --git a/content/public/test/mock_render_thread.h b/content/public/test/mock_render_thread.h
index 7b6c7d3..5301acf 100644
--- a/content/public/test/mock_render_thread.h
+++ b/content/public/test/mock_render_thread.h
@@ -63,7 +63,6 @@ class MockRenderThread : public RenderThread {
void RemoveObserver(RenderProcessObserver* observer) override;
void SetResourceDispatcherDelegate(
ResourceDispatcherDelegate* delegate) override;
- void EnsureWebKitInitialized() override;
void RecordAction(const base::UserMetricsAction& action) override;
void RecordComputedAction(const std::string& action) override;
scoped_ptr<base::SharedMemory> HostAllocateSharedMemoryBuffer(