diff options
| author | yurys <yurys@chromium.org> | 2014-10-28 06:27:39 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-28 13:27:58 +0000 |
| commit | f9b12ff57fc7491e9ccaa6db69c893307bd1fee1 (patch) | |
| tree | 516c5972e8d2eb89cd15838da28bd014f5d0ab7a /content/renderer/BUILD.gn | |
| parent | 873fd0deb0013f4d3d61aa241e22bbacaaa6bbd2 (diff) | |
| download | chromium_src-f9b12ff57fc7491e9ccaa6db69c893307bd1fee1.zip chromium_src-f9b12ff57fc7491e9ccaa6db69c893307bd1fee1.tar.gz chromium_src-f9b12ff57fc7491e9ccaa6db69c893307bd1fee1.tar.bz2 | |
Revert of Partially convert geolocation IPC to Mojo. (patchset #16 id:360001 of https://codereview.chromium.org/628773003/)
Reason for revert:
Made inspector/geolocation-emulation-tests.html layout test crash on all platforms
Flakiness dashboard link:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fgeolocation-emulation-tests.html
Chromium revisions range:
https://chromium.googlesource.com/chromium/src/+log/a772ed62ff0641df984feffe977b1545e94d53f1..5a5999ebee2d83c5a8dc72b3c6035fd803fdf90d?pretty=fuller
Original issue's description:
> Partially convert geolocation IPC to Mojo.
>
> This CL converts the non-permissions-related geolocation IPC to Mojo. The Mojo
> GeolocationService interface allows clients to observe location updates. In
> //content, the service and its client connect on a per-frame basis, eliminating
> the need for the tracking of multiple frames that GeolocationDispatcherHost had
> previously been doing. To handle the fact that geolocation updates can be
> paused and resumed at per-WebContents granularity, we introduce a
> GeolocationServiceContext class, which is used to scope the granularity of
> pauses and resumes.
>
> Currently, GeolocationDispatcherHost still handles permissions-related
> geolocation IPC. This IPC will be moved to Mojo once there is resolution on
> what the right model for handling permissions there is.
>
> BUG=420497
> TEST=Go to maps.google.com, allow location tracking, and check that your
> location is correctly pinpointed on the map.
>
> Committed: https://crrev.com/28e88081438dc08b06d5f05cfdd980c407db1638
> Cr-Commit-Position: refs/heads/master@{#301604}
TBR=qsr@chromium.org,mvanouwerkerk@chromium.org,timvolodine@chromium.org,brettw@chromium.org,creis@chromium.org,tsepez@chromium.org,aa@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420497
Review URL: https://codereview.chromium.org/680323002
Cr-Commit-Position: refs/heads/master@{#301629}
Diffstat (limited to 'content/renderer/BUILD.gn')
| -rw-r--r-- | content/renderer/BUILD.gn | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/content/renderer/BUILD.gn b/content/renderer/BUILD.gn index a9b54c2..388570b 100644 --- a/content/renderer/BUILD.gn +++ b/content/renderer/BUILD.gn @@ -31,7 +31,6 @@ source_set("renderer") { "//content/common:mojo_bindings", "//content/public/child:child_sources", "//content/public/common:common_sources", - "//content/public/common:mojo_bindings", "//gin", "//gpu", "//gpu/command_buffer/client:gles2_interface", |