base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().

This ensures that if the header is not included, and a DCHECK is guarded
by this check, that the file will fail to compile instead of silently
compiling the DCHECK out.

For example:

#if DCHECK_IS_ON
DCHECK(SomeThing());
#endif

This example would be compiled out if DCHECK_IS_ON was not defined due
to not including the logging.h header.

Instead, this will fail to compile:

#if DCHECK_IS_ON()
DCHECK(SomeThing());
#endif

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/842523002

Cr-Commit-Position: refs/heads/master@{#310626}

1 files changed, 5 insertions, 5 deletions

diff --git a/content/renderer/gpu/queue_message_swap_promise.cc b/content/renderer/gpu/queue_message_swap_promise.cc
index 1cb5316..c8abf89 100644
--- a/content/renderer/gpu/queue_message_swap_promise.cc
+++ b/content/renderer/gpu/queue_message_swap_promise.cc
@@ -16,7 +16,7 @@ QueueMessageSwapPromise::QueueMessageSwapPromise(
     : message_sender_(message_sender),
       message_queue_(message_queue),
       source_frame_number_(source_frame_number)
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
       ,
       completed_(false)
 #endif
@@ -27,13 +27,13 @@ QueueMessageSwapPromise::QueueMessageSwapPromise(
 
 QueueMessageSwapPromise::~QueueMessageSwapPromise() {
   // The promise should have either been kept or broken before it's deleted.
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
   DCHECK(completed_);
 #endif
 }
 
 void QueueMessageSwapPromise::DidSwap(cc::CompositorFrameMetadata* metadata) {
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
   DCHECK(!completed_);
 #endif
   message_queue_->DidSwap(source_frame_number_);
@@ -42,7 +42,7 @@ void QueueMessageSwapPromise::DidSwap(cc::CompositorFrameMetadata* metadata) {
 }
 
 void QueueMessageSwapPromise::DidNotSwap(DidNotSwapReason reason) {
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
   DCHECK(!completed_);
 #endif
   ScopedVector<IPC::Message> messages;
@@ -57,7 +57,7 @@ void QueueMessageSwapPromise::DidNotSwap(DidNotSwapReason reason) {
 }
 
 void QueueMessageSwapPromise::PromiseCompleted() {
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
   completed_ = true;
 #endif
 }