summaryrefslogtreecommitdiffstats
path: root/content/renderer/web_ui_extension.cc
diff options
context:
space:
mode:
authordcarney@google.com <dcarney@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-28 16:47:24 +0000
committerdcarney@google.com <dcarney@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-28 16:47:24 +0000
commit89cee33bd33769684e2261f6d79446dafdbdcf7c (patch)
treeae5cffe51f330e81bba66f4e8c575d6b61fc4d73 /content/renderer/web_ui_extension.cc
parent53cd60ca49479698a0e885a721d010ed404019d5 (diff)
downloadchromium_src-89cee33bd33769684e2261f6d79446dafdbdcf7c.zip
chromium_src-89cee33bd33769684e2261f6d79446dafdbdcf7c.tar.gz
chromium_src-89cee33bd33769684e2261f6d79446dafdbdcf7c.tar.bz2
Remove usages of deprecated v8 apis in extensions in content/renderer
TBR=jochen@chromium.org BUG=324225 Review URL: https://codereview.chromium.org/95533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237804 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/web_ui_extension.cc')
-rw-r--r--content/renderer/web_ui_extension.cc21
1 files changed, 13 insertions, 8 deletions
diff --git a/content/renderer/web_ui_extension.cc b/content/renderer/web_ui_extension.cc
index 2675f39..f887e9d 100644
--- a/content/renderer/web_ui_extension.cc
+++ b/content/renderer/web_ui_extension.cc
@@ -48,7 +48,8 @@ class WebUIExtensionWrapper : public v8::Extension {
WebUIExtensionWrapper();
virtual ~WebUIExtensionWrapper();
- virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(
+ virtual v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(
+ v8::Isolate* isolate,
v8::Handle<v8::String> name) OVERRIDE;
static void Send(const v8::FunctionCallbackInfo<v8::Value>& args);
static void GetVariableValue(const v8::FunctionCallbackInfo<v8::Value>& args);
@@ -65,12 +66,13 @@ WebUIExtensionWrapper::WebUIExtensionWrapper()
WebUIExtensionWrapper::~WebUIExtensionWrapper() {}
-v8::Handle<v8::FunctionTemplate> WebUIExtensionWrapper::GetNativeFunction(
- v8::Handle<v8::String> name) {
- if (name->Equals(v8::String::New("Send")))
- return v8::FunctionTemplate::New(Send);
- if (name->Equals(v8::String::New("GetVariableValue")))
- return v8::FunctionTemplate::New(GetVariableValue);
+v8::Handle<v8::FunctionTemplate>
+WebUIExtensionWrapper::GetNativeFunctionTemplate(v8::Isolate* isolate,
+ v8::Handle<v8::String> name) {
+ if (name->Equals(v8::String::NewFromUtf8(isolate, "Send")))
+ return v8::FunctionTemplate::New(isolate, Send);
+ if (name->Equals(v8::String::NewFromUtf8(isolate, "GetVariableValue")))
+ return v8::FunctionTemplate::New(isolate, GetVariableValue);
return v8::Handle<v8::FunctionTemplate>();
}
@@ -155,7 +157,10 @@ void WebUIExtensionWrapper::GetVariableValue(
std::string key = *v8::String::Utf8Value(args[0]->ToString());
std::string value = WebUIExtensionData::Get(render_view)->GetValue(key);
- args.GetReturnValue().Set(v8::String::New(value.c_str(), value.length()));
+ args.GetReturnValue().Set(v8::String::NewFromUtf8(args.GetIsolate(),
+ value.c_str(),
+ v8::String::kNormalString,
+ value.length()));
}
// static