summaryrefslogtreecommitdiffstats
path: root/content/test/layout_test_http_server.cc
diff options
context:
space:
mode:
authorrsimha@google.com <rsimha@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-12 21:53:15 +0000
committerrsimha@google.com <rsimha@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-12 21:53:15 +0000
commit2bbc7f262c7210f275b7c1df823fcb4ef808c6d8 (patch)
tree58698f38e31b69c0222ad6ce8a0fc92c9b9c55cf /content/test/layout_test_http_server.cc
parent09be0c3b503fade4be4ab945ab5987dbfdf190dc (diff)
downloadchromium_src-2bbc7f262c7210f275b7c1df823fcb4ef808c6d8.zip
chromium_src-2bbc7f262c7210f275b7c1df823fcb4ef808c6d8.tar.gz
chromium_src-2bbc7f262c7210f275b7c1df823fcb4ef808c6d8.tar.bz2
Reland: Take 2: Force python test server output to be unbuffered, so it doesn't mix with gtest output
In browser tests that use a local python server, the python output in the test logs sometimes overlaps with gtest output, resulting in gtest falsely detecting passing tests as incomplete. This is a result of python's default use of buffered output, which gets written to the log file out of order. This patch forces the python process for local test servers to use unbuffered mode via the -u switch. This way, by the time gtest is ready to log a passing test, all testserver output is already written to the log file. Update: The win xp bots were adversely affected by the -u switch, so we now apply it only for mac and linux, which is where the original problem was found. BUG=147368 TEST=See sync integration test output when it is redirected to a log file, and make sure there are no false negatives. Originally committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156361 Review URL: https://codereview.chromium.org/10907162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156389 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/test/layout_test_http_server.cc')
-rw-r--r--content/test/layout_test_http_server.cc4
1 files changed, 1 insertions, 3 deletions
diff --git a/content/test/layout_test_http_server.cc b/content/test/layout_test_http_server.cc
index 783c596..37f04e4 100644
--- a/content/test/layout_test_http_server.cc
+++ b/content/test/layout_test_http_server.cc
@@ -23,10 +23,8 @@ bool PrepareCommandLine(CommandLine* cmd_line) {
if (!PathService::Get(base::DIR_SOURCE_ROOT, &src_path))
return false;
- FilePath python_runtime;
- if (!GetPythonRunTime(&python_runtime))
+ if (!GetPythonCommand(cmd_line))
return false;
- cmd_line->SetProgram(python_runtime);
FilePath script_path(src_path);
script_path = script_path.AppendASCII("third_party");