diff options
author | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-28 18:36:43 +0000 |
---|---|---|
committer | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-28 18:36:43 +0000 |
commit | 1de7a171610b6c5f50c5ff2a45b9bee4c871e369 (patch) | |
tree | 0aefbb0db1babb9c65ada2da9d61f31ba8ee72c6 /content/test/run_all_unittests.cc | |
parent | 35a6fd1817d0c50fa40545c45711623627133954 (diff) | |
download | chromium_src-1de7a171610b6c5f50c5ff2a45b9bee4c871e369.zip chromium_src-1de7a171610b6c5f50c5ff2a45b9bee4c871e369.tar.gz chromium_src-1de7a171610b6c5f50c5ff2a45b9bee4c871e369.tar.bz2 |
Move RegisterContentSchemes from public url_constants into non-public url_schemes.
The VC++ linker can only discard whole .obj files that aren't used. setup.exe and npchrome_frame.dll pull in constants from url_constants.cc. http://crrev.com/133107 put RegisterContentSchemes into that file. This function's use of ContentClient causes all of WebKit and V8 to be pulled into setup.exe and npchrome_frame.dll.
This change here moves RegisterContentSchemes into its own .cc file to get around link.exe's .obj-level code omission policy.
This is a hack, and I feel shame for committing it. In the long run, we need a way to prevent changes that lead to a 6x increase in the size of the binaries spat out by the official builders. One could imagine this being done by a stage in a try run that goes red, or some build-time enforcement. Perhaps the constants should even go in their own target so that consumers of nothing but constants don't accidentally get content's transient dependencies.
BUG=127564
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10383298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139253 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/test/run_all_unittests.cc')
-rw-r--r-- | content/test/run_all_unittests.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/content/test/run_all_unittests.cc b/content/test/run_all_unittests.cc index 2a66953..1c3c576 100644 --- a/content/test/run_all_unittests.cc +++ b/content/test/run_all_unittests.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -6,5 +6,5 @@ #include "content/test/unittest_test_suite.h" int main(int argc, char** argv) { - return UnitTestTestSuite(new ContentTestSuite(argc, argv)).Run(); + return UnitTestTestSuite(new content::ContentTestSuite(argc, argv)).Run(); } |