diff options
author | avi <avi@chromium.org> | 2015-04-27 18:30:02 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-04-28 01:29:57 +0000 |
commit | 5671403d44971669e4d81aecf3f002188ce0e95f (patch) | |
tree | 176e6bd1fa7b002d7d3a7d88c5c1e16b47550ba5 /content/test/test_render_frame_host.h | |
parent | 3029d2b48c15ea0f15e918d705ca6863d3e2172b (diff) | |
download | chromium_src-5671403d44971669e4d81aecf3f002188ce0e95f.zip chromium_src-5671403d44971669e4d81aecf3f002188ce0e95f.tar.gz chromium_src-5671403d44971669e4d81aecf3f002188ce0e95f.tar.bz2 |
Classify navigations without page id in parallel to the existing classifier.
For now, this only happens in debug builds.
BUG=369661
TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
TEST=Every other test on the planet.
Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
Cr-Commit-Position: refs/heads/master@{#327122}
Reverted: https://crrev.com/5348e920f4119aff9a4eb76c0965725dc85a66cc
Cr-Revert-Position: refs/heads/master@{#327152}
Review URL: https://codereview.chromium.org/1002803002
Cr-Commit-Position: refs/heads/master@{#327214}
Diffstat (limited to 'content/test/test_render_frame_host.h')
-rw-r--r-- | content/test/test_render_frame_host.h | 55 |
1 files changed, 36 insertions, 19 deletions
diff --git a/content/test/test_render_frame_host.h b/content/test/test_render_frame_host.h index 798479f..3b0c9ae 100644 --- a/content/test/test_render_frame_host.h +++ b/content/test/test_render_frame_host.h @@ -52,35 +52,50 @@ class TestRenderFrameHost : public RenderFrameHostImpl, // RenderFrameHostTester implementation. TestRenderFrameHost* AppendChild(const std::string& frame_name) override; - void SendNavigate(int page_id, const GURL& url) override; - void SendFailedNavigate(int page_id, const GURL& url) override; + void SendNavigate(int page_id, + int nav_entry_id, + bool did_create_new_entry, + const GURL& url) override; + void SendFailedNavigate(int page_id, + int nav_entry_id, + bool did_create_new_entry, + const GURL& url) override; void SendNavigateWithTransition(int page_id, + int nav_entry_id, + bool did_create_new_entry, const GURL& url, ui::PageTransition transition) override; void SetContentsMimeType(const std::string& mime_type) override; void SendBeforeUnloadACK(bool proceed) override; void SimulateSwapOutACK() override; - void SendNavigateWithTransitionAndResponseCode( - int page_id, - const GURL& url, ui::PageTransition transition, - int response_code); - void SendNavigateWithOriginalRequestURL( - int page_id, - const GURL& url, - const GURL& original_request_url); - void SendNavigateWithFile( - int page_id, - const GURL& url, - const base::FilePath& file_path); + void SendNavigateWithTransitionAndResponseCode(int page_id, + int nav_entry_id, + bool did_create_new_entry, + const GURL& url, + ui::PageTransition transition, + int response_code); + void SendNavigateWithOriginalRequestURL(int page_id, + int nav_entry_id, + bool did_create_new_entry, + const GURL& url, + const GURL& original_request_url); + void SendNavigateWithFile(int page_id, + int nav_entry_id, + bool did_create_new_entry, + const GURL& url, + const base::FilePath& file_path); void SendNavigateWithParams( FrameHostMsg_DidCommitProvisionalLoad_Params* params); - void SendNavigateWithRedirects( - int page_id, - const GURL& url, - const std::vector<GURL>& redirects); + void SendNavigateWithRedirects(int page_id, + int nav_entry_id, + bool did_create_new_entry, + const GURL& url, + const std::vector<GURL>& redirects); void SendNavigateWithParameters( int page_id, + int nav_entry_id, + bool did_create_new_entry, const GURL& url, ui::PageTransition transition, const GURL& original_request_url, @@ -89,7 +104,9 @@ class TestRenderFrameHost : public RenderFrameHostImpl, const std::vector<GURL>& redirects); // Simulate a renderer-initiated navigation up until commit. - void NavigateAndCommitRendererInitiated(int page_id, const GURL& url); + void NavigateAndCommitRendererInitiated(int page_id, + bool did_create_new_entry, + const GURL& url); // With the current navigation logic this method is a no-op. // PlzNavigate: this method simulates receiving a BeginNavigation IPC. |