diff options
| author | cmumford <cmumford@chromium.org> | 2015-06-19 10:58:10 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-19 17:58:43 +0000 |
| commit | 47615e97e76f04e213f56a1472484bf1e1542ed0 (patch) | |
| tree | fc32a8407b776cbd59176bdb088cc0d02e436d8d /content | |
| parent | 4dac85e8857e3adec857749c68a893e8f1448e7d (diff) | |
| download | chromium_src-47615e97e76f04e213f56a1472484bf1e1542ed0.zip chromium_src-47615e97e76f04e213f56a1472484bf1e1542ed0.tar.gz chromium_src-47615e97e76f04e213f56a1472484bf1e1542ed0.tar.bz2 | |
WebSQL: Removed unused reportOpenDatabaseResult.
Removed the older version of reportOpenDatabaseResult w/o the
open time parameter.
Part 2 of 2 to add database open statistics reporting.
BUG=497960
Review URL: https://codereview.chromium.org/1172443003
Cr-Commit-Position: refs/heads/master@{#335288}
Diffstat (limited to 'content')
| -rw-r--r-- | content/child/web_database_observer_impl.cc | 15 | ||||
| -rw-r--r-- | content/child/web_database_observer_impl.h | 4 |
2 files changed, 4 insertions, 15 deletions
diff --git a/content/child/web_database_observer_impl.cc b/content/child/web_database_observer_impl.cc index 98b1cd7..68534a2 100644 --- a/content/child/web_database_observer_impl.cc +++ b/content/child/web_database_observer_impl.cc @@ -92,21 +92,14 @@ void WebDatabaseObserverImpl::databaseClosed( void WebDatabaseObserverImpl::reportOpenDatabaseResult( const WebString& origin_identifier, const WebString& database_name, - int callsite, int websql_error, int sqlite_error) { - UMA_HISTOGRAM_WEBSQL_RESULT("OpenResult", callsite, - websql_error, sqlite_error); - HandleSqliteError(origin_identifier, database_name, sqlite_error); -} - -void WebDatabaseObserverImpl::reportOpenDatabaseResult( - const WebString& origin_identifier, - const WebString& database_name, int callsite, int websql_error, int sqlite_error, double call_time) { - reportOpenDatabaseResult(origin_identifier, database_name, callsite, - websql_error, sqlite_error); + UMA_HISTOGRAM_WEBSQL_RESULT("OpenResult", callsite, + websql_error, sqlite_error); + HandleSqliteError(origin_identifier, database_name, sqlite_error); + if (websql_error == kWebSQLSuccess && sqlite_error == SQLITE_OK) { UMA_HISTOGRAM_TIMES("websql.Async.OpenTime.Success", base::TimeDelta::FromSecondsD(call_time)); diff --git a/content/child/web_database_observer_impl.h b/content/child/web_database_observer_impl.h index c8e1f28..a1924ea 100644 --- a/content/child/web_database_observer_impl.h +++ b/content/child/web_database_observer_impl.h @@ -31,10 +31,6 @@ class WebDatabaseObserverImpl : public blink::WebDatabaseObserver { virtual void reportOpenDatabaseResult( const blink::WebString& origin_identifier, const blink::WebString& database_name, - int callsite, int websql_error, int sqlite_error); - virtual void reportOpenDatabaseResult( - const blink::WebString& origin_identifier, - const blink::WebString& database_name, int callsite, int websql_error, int sqlite_error, |