diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-17 23:27:26 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-17 23:27:26 +0000 |
| commit | 5ee06906ce7254ae1f132f0e5f67185e7df3ad56 (patch) | |
| tree | 3acc8a2473964171fd43e6efdfe9f5436a11f158 /content | |
| parent | 76021c373be1328bd8214b19c9d6c04c2ffd8c6f (diff) | |
| download | chromium_src-5ee06906ce7254ae1f132f0e5f67185e7df3ad56.zip chromium_src-5ee06906ce7254ae1f132f0e5f67185e7df3ad56.tar.gz chromium_src-5ee06906ce7254ae1f132f0e5f67185e7df3ad56.tar.bz2 | |
Remove toolstrips from Chrome.
BUG=100488
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8315005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105959 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/browser/renderer_host/backing_store_manager.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/content/browser/renderer_host/backing_store_manager.cc b/content/browser/renderer_host/backing_store_manager.cc index 19e9807..16e84b5 100644 --- a/content/browser/renderer_host/backing_store_manager.cc +++ b/content/browser/renderer_host/backing_store_manager.cc @@ -16,7 +16,7 @@ namespace { // There are two separate caches, |large_cache| and |small_cache|. large_cache // is meant for large items (tabs, popup windows), while small_cache is meant -// for small items (extension toolstrips and buttons, etc.). The idea is that +// for small items (extension popups, HTML5 notifications). The idea is that // we'll almost always try to evict from large_cache first since small_cache // items will tend to be visible more of the time. typedef base::OwningMRUCache<RenderWidgetHost*, BackingStore*> @@ -26,7 +26,11 @@ static BackingStoreCache* small_cache = NULL; // Threshold is based on a single large-monitor-width toolstrip. // (32bpp, 32 pixels high, 1920 pixels wide) -// TODO(erikkay) 32bpp assumption isn't great. +// TODO(aa): The extension system no longer supports toolstrips, but we think +// this might be helping for other examples of small HTML views in Chrome. +// Maybe this cache should be redesigned to simply prefer smaller objects to +// larger ones, rather than having a fixed threshold. +// For more background, see: crbug.com/100506. const size_t kSmallThreshold = 4 * 32 * 1920; // Pick a large monitor size to use as a multiplier. This is multiplied by the |