diff options
author | hiroshige <hiroshige@chromium.org> | 2015-03-12 04:07:17 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-12 11:08:10 +0000 |
commit | 6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871 (patch) | |
tree | 097eec36c08d95dbf120f3aac52ca8f1432b5c5d /content | |
parent | 3c72daf174fd047233a5bcc33259628e1406b730 (diff) | |
download | chromium_src-6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871.zip chromium_src-6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871.tar.gz chromium_src-6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871.tar.bz2 |
Add WebSocketDispatcherHostTest.InvalidScheme
This is a regression test for
https://codereview.chromium.org/998173003/.
BUG=466335
Review URL: https://codereview.chromium.org/1000883004
Cr-Commit-Position: refs/heads/master@{#320262}
Diffstat (limited to 'content')
-rw-r--r-- | content/browser/renderer_host/websocket_dispatcher_host_unittest.cc | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/content/browser/renderer_host/websocket_dispatcher_host_unittest.cc b/content/browser/renderer_host/websocket_dispatcher_host_unittest.cc index 088f85d..4eb1104 100644 --- a/content/browser/renderer_host/websocket_dispatcher_host_unittest.cc +++ b/content/browser/renderer_host/websocket_dispatcher_host_unittest.cc @@ -410,5 +410,33 @@ TEST_F(WebSocketDispatcherHostTest, NotRejectedAfter255FailedConnections) { EXPECT_EQ(0, dispatcher_host_->num_succeeded_connections()); } +// This is a regression test for https://crrev.com/998173003/. +TEST_F(WebSocketDispatcherHostTest, InvalidScheme) { + int routing_id = 123; + GURL socket_url("http://example.com/test"); + std::vector<std::string> requested_protocols; + requested_protocols.push_back("hello"); + url::Origin origin("http://example.com"); + int render_frame_id = -2; + WebSocketHostMsg_AddChannelRequest message( + routing_id, socket_url, requested_protocols, origin, render_frame_id); + + ASSERT_TRUE(dispatcher_host_->OnMessageReceived(message)); + + ASSERT_EQ(1U, mock_hosts_.size()); + MockWebSocketHost* host = mock_hosts_[0]; + + // Tests that WebSocketHost::OnMessageReceived() doesn't cause a crash and + // the connection with an invalid scheme fails here. + // We call WebSocketHost::OnMessageReceived() here explicitly because + // MockWebSocketHost does not call WebSocketHost::OnMessageReceived() for + // WebSocketHostMsg_AddChannelRequest. + host->WebSocketHost::OnMessageReceived(message); + + EXPECT_EQ(0, dispatcher_host_->num_pending_connections()); + EXPECT_EQ(1, dispatcher_host_->num_failed_connections()); + EXPECT_EQ(0, dispatcher_host_->num_succeeded_connections()); +} + } // namespace } // namespace content |