Several fixes to the UI for enabling SIM-locked modems.

- Clicking "Enable Mobile Data" from either the network dropdown
menu or the internet settings page results in the SIM unlock dialog
being posted if the SIM is locked.
- If the Enable button on the settings page was pressed, and the SIM
unlock dialog is cancel, the Enable button, which had been disabled
(greyed out) when clicked, is re-enabled.
- If the correct PIN (or PUK) is entered, and the SIM becomes unlocked,
we now perform the actual device enable operation.

Also changed the definitions of the PIN error messages, to match an
about-to-be-committed change made on the flimflam side.

BUG=chromium-os-partner:3538
TEST=Press enable on the settings page, bringing up unlock dialog.
- Cancel the dialog. See that the Enable button is active.
- Enter an incorrect PIN and see that it behaves as before, i.e.,
the dialog stays up and reports the new retries-allowed count.
- Enter the correct PIN and see that the device becomes enabled, and
the button changes to "Disable Mobile Data".

Try all three of the above scenarios using the Enable choice in
the network dropdown menu, with and without any Chrome tab displaying
the settings page. Make sure the results are the same as they were when
the Enable button on the settings page was used (except of course,
the Enable button won't be displayed, so the part where you check
that it's active after cancelling doesn't apply.

R=stevenjb@chromium.org,nkostylev@chromium.org,zelidrag@chromium.org

Review URL: http://codereview.chromium.org/7075015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87082 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 0 deletions

diff --git a/content/common/notification_type.h b/content/common/notification_type.h
index 98d2ad0..b5b0b3d 100644
--- a/content/common/notification_type.h
+++ b/content/common/notification_type.h
@@ -1251,6 +1251,12 @@ class NotificationType {
     // In either case notification is sent and details contain a bool
     // that represents current value.
     REQUIRE_PIN_SETTING_CHANGE_ENDED,
+
+    // Sent by SIM unlock dialog when it has finished the EnterPin or
+    // EnterPuk dialog, either because the user cancelled, or entered a
+    // PIN or PUK.
+    ENTER_PIN_ENDED,
+
 #endif
 
     // Sent before the repost form warning is brought up.