diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-17 21:45:08 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-17 21:45:08 +0000 |
| commit | a1a705e9f2fdd6e8ecb63cfe20c8412cd7c45766 (patch) | |
| tree | f24bb8e4f58420274e7af9015cfca4734da7521a /content | |
| parent | 14506194d51c115e1c0c6a2ccc80113d79280991 (diff) | |
| download | chromium_src-a1a705e9f2fdd6e8ecb63cfe20c8412cd7c45766.zip chromium_src-a1a705e9f2fdd6e8ecb63cfe20c8412cd7c45766.tar.gz chromium_src-a1a705e9f2fdd6e8ecb63cfe20c8412cd7c45766.tar.bz2 | |
Add DEPS rules to help enforce the general rule that the embedder should provide URLs and access tokens to server-side services.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11573034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173538 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/DEPS | 14 | ||||
| -rw-r--r-- | content/browser/geolocation/DEPS | 4 | ||||
| -rw-r--r-- | content/browser/speech/DEPS | 1 |
3 files changed, 17 insertions, 2 deletions
diff --git a/content/DEPS b/content/DEPS index 0362df1..e615c72f 100644 --- a/content/DEPS +++ b/content/DEPS @@ -15,8 +15,6 @@ include_rules = [ "+content/shell", # for content_browsertests "+content/test", - "+google_apis", - "+grit/content_resources.h", "+grit/ui_resources.h", "+grit/webkit_chromium_resources.h", @@ -31,6 +29,18 @@ include_rules = [ "+sandbox", "+skia", + # In general, content/ should not rely on google_apis, since URLs + # and access tokens should usually be provided by the + # embedder. + # + # There are a couple of specific parts of content that are excepted + # from this rule, see content/browser/speech/DEPS and + # content/browser/geolocation/DEPS. Both of these are cases of + # implementations that are strongly tied to Google servers, i.e. we + # don't expect alternate implementations to be provided by the + # embedder. + "-google_apis", + # Don't allow inclusion of these other libs we shouldn't be calling directly. "-v8", "-tools", diff --git a/content/browser/geolocation/DEPS b/content/browser/geolocation/DEPS new file mode 100644 index 0000000..9f09a70 --- /dev/null +++ b/content/browser/geolocation/DEPS @@ -0,0 +1,4 @@ +include_rules = [ + "+google_apis", # Exception to general rule, see content/DEPS for details. +] + diff --git a/content/browser/speech/DEPS b/content/browser/speech/DEPS index 8fac8f4..b0e678d 100644 --- a/content/browser/speech/DEPS +++ b/content/browser/speech/DEPS @@ -1,3 +1,4 @@ include_rules = [ + "+google_apis", # Exception to general rule, see content/DEPS for details. "+media/audio", # For audio input. ] |