diff options
author | kaiwang@chromium.org <kaiwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-20 23:53:15 +0000 |
---|---|---|
committer | kaiwang@chromium.org <kaiwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-20 23:53:15 +0000 |
commit | e58234cc489a5dfde135064f63d1dc67bf2bf048 (patch) | |
tree | ba3d7e8c369aa301943fff41be2a1382d4a0f73e /content | |
parent | 33ca7f66564794bd262db4c6f0cc2f8083859fa9 (diff) | |
download | chromium_src-e58234cc489a5dfde135064f63d1dc67bf2bf048.zip chromium_src-e58234cc489a5dfde135064f63d1dc67bf2bf048.tar.gz chromium_src-e58234cc489a5dfde135064f63d1dc67bf2bf048.tar.bz2 |
Add comments to HistogramFlatterner interface and rename a function
Review URL: https://chromiumcodereview.appspot.com/10857067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152434 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
-rw-r--r-- | content/common/child_histogram_message_filter.cc | 9 | ||||
-rw-r--r-- | content/common/child_histogram_message_filter.h | 8 |
2 files changed, 11 insertions, 6 deletions
diff --git a/content/common/child_histogram_message_filter.cc b/content/common/child_histogram_message_filter.cc index 85d905c..a0ca7b9 100644 --- a/content/common/child_histogram_message_filter.cc +++ b/content/common/child_histogram_message_filter.cc @@ -81,17 +81,20 @@ void ChildHistogramMessageFilter::RecordDelta( pickled_histograms_.push_back(histogram_info); } -void ChildHistogramMessageFilter::InconsistencyDetected(int problem) { +void ChildHistogramMessageFilter::InconsistencyDetected( + base::Histogram::Inconsistencies problem) { UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesChildProcess", problem, base::Histogram::NEVER_EXCEEDED_VALUE); } -void ChildHistogramMessageFilter::UniqueInconsistencyDetected(int problem) { +void ChildHistogramMessageFilter::UniqueInconsistencyDetected( + base::Histogram::Inconsistencies problem) { UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesChildProcessUnique", problem, base::Histogram::NEVER_EXCEEDED_VALUE); } -void ChildHistogramMessageFilter::SnapshotProblemResolved(int amount) { +void ChildHistogramMessageFilter::InconsistencyDetectedInLoggedCount( + int amount) { UMA_HISTOGRAM_COUNTS("Histogram.InconsistentSnapshotChildProcess", std::abs(amount)); } diff --git a/content/common/child_histogram_message_filter.h b/content/common/child_histogram_message_filter.h index ce9a348..c28fb8e 100644 --- a/content/common/child_histogram_message_filter.h +++ b/content/common/child_histogram_message_filter.h @@ -33,9 +33,11 @@ class ChildHistogramMessageFilter : public base::HistogramFlattener, // HistogramFlattener interface (override) methods. virtual void RecordDelta(const base::Histogram& histogram, const base::Histogram::SampleSet& snapshot) OVERRIDE; - virtual void InconsistencyDetected(int problem) OVERRIDE; - virtual void UniqueInconsistencyDetected(int problem) OVERRIDE; - virtual void SnapshotProblemResolved(int amount) OVERRIDE; + virtual void InconsistencyDetected( + base::Histogram::Inconsistencies problem) OVERRIDE; + virtual void UniqueInconsistencyDetected( + base::Histogram::Inconsistencies problem) OVERRIDE; + virtual void InconsistencyDetectedInLoggedCount(int amount) OVERRIDE; private: typedef std::vector<std::string> HistogramPickledList; |