diff options
author | huangs <huangs@chromium.org> | 2015-09-08 11:27:29 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-08 18:28:18 +0000 |
commit | 558063b7f257e2cbd545e8c465cd0b51803c24f5 (patch) | |
tree | 70547d799b45ec21d085fc019bbb4ff19e7f2957 /courgette/courgette_config.h | |
parent | 6cc5dbbc5fc7b3e505f1d13488810eda479dd0a6 (diff) | |
download | chromium_src-558063b7f257e2cbd545e8c465cd0b51803c24f5.zip chromium_src-558063b7f257e2cbd545e8c465cd0b51803c24f5.tar.gz chromium_src-558063b7f257e2cbd545e8c465cd0b51803c24f5.tar.bz2 |
Revert of [Courgette] Adding CourgetteConfig singleton and --experimental flag. (patchset #5 id:80001 of https://chromiumcodereview.appspot.com/1306193004/ )
Reason for revert:
The original CL assumes Courgette had to deal with forward/backward compatibility issues.
Turns out that (as seen in http://crbug.com/459505):
- Courgette executable is shipped with new releases.
- This allows Courgette workflow to proceed without being tied down to legacy.
These new (to huangs@) facts render the original CL redundant.
Original issue's description:
> [Courgette] Adding CourgetteConfig singleton and --experimental flag.
>
> This prepare for upcoming experiments to reduce patch size. We want to
> avoid disrupting existing functionality.
>
> Committed: https://crrev.com/fc0511d9067759336f42d04e918e8a3ce0b84376
> Cr-Commit-Position: refs/heads/master@{#346746}
TBR=wfh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1323263007
Cr-Commit-Position: refs/heads/master@{#347746}
Diffstat (limited to 'courgette/courgette_config.h')
-rw-r--r-- | courgette/courgette_config.h | 39 |
1 files changed, 0 insertions, 39 deletions
diff --git a/courgette/courgette_config.h b/courgette/courgette_config.h deleted file mode 100644 index cbcfc22..0000000 --- a/courgette/courgette_config.h +++ /dev/null @@ -1,39 +0,0 @@ -// Copyright 2015 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef COURGETTE_COURGETTE_CONFIG_H_ -#define COURGETTE_COURGETTE_CONFIG_H_ - -#include "base/macros.h" -#include "base/memory/singleton.h" - -namespace base { -class CommandLine; -} // namespace base - -namespace courgette { - -// A singleton class to hold global configurations for Courgette, mainly for -// experimental purposes. -class CourgetteConfig { - public: - static CourgetteConfig* GetInstance(); - - void Initialize(const base::CommandLine& command_line); - - bool is_experimental() const { return is_experimental_; } - - uint32 ensemble_version() const; - - private: - bool is_experimental_; - - CourgetteConfig(); - - friend struct DefaultSingletonTraits<CourgetteConfig>; -}; - -} // namespace courgette - -#endif // COURGETTE_COURGETTE_CONFIG_H_ |