diff options
author | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-18 22:44:10 +0000 |
---|---|---|
committer | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-18 22:44:10 +0000 |
commit | 43823995b45f01bbf8549cbf195a7aea7cb1227d (patch) | |
tree | b2344462519a68b647a09598a4e528ae7ad4c8a5 /courgette/encoded_program.cc | |
parent | d5e435f4e11722f94fff5bea5a0ce984a8cb5612 (diff) | |
download | chromium_src-43823995b45f01bbf8549cbf195a7aea7cb1227d.zip chromium_src-43823995b45f01bbf8549cbf195a7aea7cb1227d.tar.gz chromium_src-43823995b45f01bbf8549cbf195a7aea7cb1227d.tar.bz2 |
Separate NetworkLibraryImpl into ImplBase and ImplCros
This will increase the functionality and testability of NetworkLibraryImplStub.
This CL should have no functionality change, however it touches most NetworkLibrary code paths.
Changes include:
* NetworkLibraryImpl is now NetworkLibraryImplBase.
* NetworkLibraryImplCros and NetworkLibraryImplStub inherit from NetworkLibraryImplBase.
* All libcros calls that were in NetworkLibraryImpl have been moved to NetworkLibraryImplCros.
* NetworkObserverList and NetworkDeviceObserverList are no longer classes.
** NetworkLibraryImplBase contains just the ObserverList<> maps.
** NetworkLibraryImplCros contains separate PropertyChangeMonitor maps.
** NetworkLibraryImplCros maintains a no-op NetworkDeviceObserver entry for each device to ensure that devices are always monitored (rather than have special device observer list code).
* All libcros calls should now be preceded by chromeos::
* If EnsureCrosLoaded() is false, we construct ImplStub instead of ImplCros, rather than checking each function call.
* The async connect state machine is implemented in ImplBase so that it can (eventually) be better tested and maintained, with virtual functions in ImplCros making the libcros calls (and trivial implementations in ImplStub).
* The network property parsing state machine is implemented in ImplCros, since it is (currently) highly libcros specific.
BUG=chromium-os:17354
TEST=Test all networking code (!)
Review URL: http://codereview.chromium.org/7362001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92916 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'courgette/encoded_program.cc')
0 files changed, 0 insertions, 0 deletions