summaryrefslogtreecommitdiffstats
path: root/courgette/ensemble_unittest.cc
diff options
context:
space:
mode:
authorpiman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-09-23 21:56:39 +0000
committerpiman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-09-23 21:56:39 +0000
commit83c3cb14a4a8629df75b509e926e3c06438391d1 (patch)
tree8426eadd3e93a53532fb54ccfb33d42c840377c1 /courgette/ensemble_unittest.cc
parent968f98483f3b025fd56b31f5942c91271b464e03 (diff)
downloadchromium_src-83c3cb14a4a8629df75b509e926e3c06438391d1.zip
chromium_src-83c3cb14a4a8629df75b509e926e3c06438391d1.tar.gz
chromium_src-83c3cb14a4a8629df75b509e926e3c06438391d1.tar.bz2
Revert 224789 "Add PE64 support to courgette"
Caused failures: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/23037/steps/courgette_unittests/logs/stdio > Add PE64 support to courgette > > Add tests for PE64 > > BUG=38784 > > Review URL: https://chromiumcodereview.appspot.com/23600063 TBR=wfh@chromium.org Review URL: https://codereview.chromium.org/23591065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224806 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'courgette/ensemble_unittest.cc')
-rw-r--r--courgette/ensemble_unittest.cc56
1 files changed, 5 insertions, 51 deletions
diff --git a/courgette/ensemble_unittest.cc b/courgette/ensemble_unittest.cc
index e2f1198..d35622f 100644
--- a/courgette/ensemble_unittest.cc
+++ b/courgette/ensemble_unittest.cc
@@ -12,8 +12,6 @@ class EnsembleTest : public BaseTest {
void TestEnsemble(std::string src_bytes, std::string tgt_bytes) const;
void PeEnsemble() const;
- void Pe64Ensemble() const;
- void Elf32Ensemble() const;
};
void EnsembleTest::TestEnsemble(std::string src_bytes,
@@ -46,52 +44,18 @@ void EnsembleTest::TestEnsemble(std::string src_bytes,
target.OriginalLength()));
}
-void EnsembleTest::Elf32Ensemble() const {
- std::list<std::string> src_ensemble;
- std::list<std::string> tgt_ensemble;
-
- src_ensemble.push_back("elf-32-1");
-
- tgt_ensemble.push_back("elf-32-2");
-
- std::string src_bytes = FilesContents(src_ensemble);
- std::string tgt_bytes = FilesContents(tgt_ensemble);
-
- src_bytes = "aaabbbccc" + src_bytes + "dddeeefff";
- tgt_bytes = "aaagggccc" + tgt_bytes + "dddeeefff";
-
- TestEnsemble(src_bytes, tgt_bytes);
-}
-
void EnsembleTest::PeEnsemble() const {
std::list<std::string> src_ensemble;
std::list<std::string> tgt_ensemble;
src_ensemble.push_back("en-US.dll");
src_ensemble.push_back("setup1.exe");
+ src_ensemble.push_back("elf-32-1");
+ src_ensemble.push_back("pe-64.exe");
tgt_ensemble.push_back("en-US.dll");
tgt_ensemble.push_back("setup2.exe");
-
- std::string src_bytes = FilesContents(src_ensemble);
- std::string tgt_bytes = FilesContents(tgt_ensemble);
-
- src_bytes = "aaabbbccc" + src_bytes + "dddeeefff";
- tgt_bytes = "aaagggccc" + tgt_bytes + "dddeeefff";
-
- TestEnsemble(src_bytes, tgt_bytes);
-}
-
-void EnsembleTest::Pe64Ensemble() const {
- std::list<std::string> src_ensemble;
- std::list<std::string> tgt_ensemble;
-
- src_ensemble.push_back("en-US-64.dll");
- src_ensemble.push_back("chrome64_1.exe");
- src_ensemble.push_back("pe-64.exe");
-
- tgt_ensemble.push_back("en-US-64.dll");
- tgt_ensemble.push_back("chrome64_2.exe");
+ tgt_ensemble.push_back("elf-32-2");
tgt_ensemble.push_back("pe-64.exe");
std::string src_bytes = FilesContents(src_ensemble);
@@ -103,17 +67,7 @@ void EnsembleTest::Pe64Ensemble() const {
TestEnsemble(src_bytes, tgt_bytes);
}
-// Ensemble tests still take too long on Windows so disabling for now
-// TODO(dgarrett) http://code.google.com/p/chromium/issues/detail?id=101614
-
-TEST_F(EnsembleTest, DISABLED_PE) {
+TEST_F(EnsembleTest, DISABLED_All) {
+ // TODO(dgarrett) http://code.google.com/p/chromium/issues/detail?id=101614
PeEnsemble();
}
-
-TEST_F(EnsembleTest, DISABLED_PE64) {
- Pe64Ensemble();
-}
-
-TEST_F(EnsembleTest, DISABLED_Elf32) {
- Elf32Ensemble();
-}