diff options
| author | tapted <tapted@chromium.org> | 2016-01-13 22:26:37 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-14 06:28:13 +0000 |
| commit | 174fde33258d2128a25982fbaded0ffeefa2cd6d (patch) | |
| tree | 8e17fc028100fe110ed4f8356c89b35e3d393b5f /courgette | |
| parent | 5b81d65c7382b3b855cbc5bd26a15cc68ef4c5e5 (diff) | |
| download | chromium_src-174fde33258d2128a25982fbaded0ffeefa2cd6d.zip chromium_src-174fde33258d2128a25982fbaded0ffeefa2cd6d.tar.gz chromium_src-174fde33258d2128a25982fbaded0ffeefa2cd6d.tar.bz2 | |
Move bit_cast from base/macros.h to its own header
There isn't much that uses bit_cast. bit_cast requires memcpy which
requires <string.h>
On Mac, <string.h> includes AvailabilityInternal.h which is half a
megabyte and defines dozens of macros. Providing <string.h> in
base/macros.h also tempts IWYU violations. Try to avoid it.
Add base/bit_cast.h and include it from the 17 files that need it. Then
remove the <string.h> #include from base/macros.h and IWYU.
BUG=395001
Review URL: https://codereview.chromium.org/399313006
Cr-Commit-Position: refs/heads/master@{#369348}
Diffstat (limited to 'courgette')
| -rw-r--r-- | courgette/difference_estimator.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/courgette/difference_estimator.cc b/courgette/difference_estimator.cc index 8b7aa29..ac9f0d4 100644 --- a/courgette/difference_estimator.cc +++ b/courgette/difference_estimator.cc @@ -10,6 +10,7 @@ #include <stddef.h> #include <stdint.h> +#include <string.h> #include "base/containers/hash_tables.h" #include "base/macros.h" |