diff options
| author | kochi <kochi@chromium.org> | 2015-01-22 00:03:19 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-22 08:04:14 +0000 |
| commit | 2bd0451c3a7f49f28495666274646a6011b8aa3d (patch) | |
| tree | 299bc732e3c1ec655ba670df78a453b4c000bd7f /courgette | |
| parent | d0a4d3ad884b558f0c55bdc5ed9bd10f4a11517e (diff) | |
| download | chromium_src-2bd0451c3a7f49f28495666274646a6011b8aa3d.zip chromium_src-2bd0451c3a7f49f28495666274646a6011b8aa3d.tar.gz chromium_src-2bd0451c3a7f49f28495666274646a6011b8aa3d.tar.bz2 | |
Revert of Revert of Revert of Isolate courgette_unittests (patchset #1 id:1 of https://codereview.chromium.org/867523002/)
Reason for revert:
Sorry for the mess - in the end, the original CL was causing the courgette_unittests failure.
Reverting the original again.
BUG=450912
Original issue's description:
> Revert of Revert of Isolate courgette_unittests (patchset #1 id:1 of https://codereview.chromium.org/865133002/)
>
> Reason for revert:
> The revert might have been wrong: reverting the revert again.
> BUG=450912
>
> Original issue's description:
> > Revert of Isolate courgette_unittests (patchset #1 id:1 of https://codereview.chromium.org/868433002/)
> >
> > Reason for revert:
> > http://crbug.com/450912
> >
> > courget_unittests is failing on Win7(dbg) bots since build#34639.
> > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34639
> >
> > Original issue's description:
> > > Isolate courgette_unittests
> > >
> > > Adding link to http://www.chromium.org/developers/testing/isolated-testing/for-swes for my future self.
> > >
> > > R=maruel@chromium.org,jochen@chromium.org
> > > TBR=jam@chromium.org
> > > BUG=98637
> > >
> > > Committed: https://crrev.com/c9bd3b9a5667a36c05592ec9d16533be91b4567c
> > > Cr-Commit-Position: refs/heads/master@{#312531}
> >
> > TBR=jam@chromium.org,jochen@chromium.org,maruel@chromium.org,scottmg@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=98637
> >
> > Committed: https://crrev.com/1bdeeeb5eae42e95f82806da9351d77a05403e67
> > Cr-Commit-Position: refs/heads/master@{#312571}
>
> TBR=jam@chromium.org,jochen@chromium.org,maruel@chromium.org,scottmg@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=98637
>
> Committed: https://crrev.com/217c53ca8128370c64a5d1a4ba15cb4cea5564ac
> Cr-Commit-Position: refs/heads/master@{#312577}
TBR=jam@chromium.org,jochen@chromium.org,maruel@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450912
Review URL: https://codereview.chromium.org/800333003
Cr-Commit-Position: refs/heads/master@{#312584}
Diffstat (limited to 'courgette')
| -rw-r--r-- | courgette/courgette.gyp | 17 | ||||
| -rw-r--r-- | courgette/courgette_unittests.isolate | 14 |
2 files changed, 0 insertions, 31 deletions
diff --git a/courgette/courgette.gyp b/courgette/courgette.gyp index bc8b7bb..52db0fb 100644 --- a/courgette/courgette.gyp +++ b/courgette/courgette.gyp @@ -213,22 +213,5 @@ }, ], }], - ['test_isolation_mode != "noop"', { - 'targets': [ - { - 'target_name': 'courgette_unittests_run', - 'type': 'none', - 'dependencies': [ - 'courgette_unittests', - ], - 'includes': [ - '../build/isolate.gypi', - ], - 'sources': [ - 'courgette_unittests.isolate', - ], - }, - ], - }], ], } diff --git a/courgette/courgette_unittests.isolate b/courgette/courgette_unittests.isolate deleted file mode 100644 index 244cde1..0000000 --- a/courgette/courgette_unittests.isolate +++ /dev/null @@ -1,14 +0,0 @@ -# Copyright 2015 The Chromium Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. -{ - 'variables': { - 'files': [ - '<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)', - 'testdata/', - ], - 'command': [ - '<(PRODUCT_DIR)/courgette_unittests<(EXECUTABLE_SUFFIX)', - ], - }, -} |