diff options
| author | ki.stfu <ki.stfu@gmail.com> | 2015-09-21 10:30:50 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-21 17:31:33 +0000 |
| commit | d0f29e1666ab81289f7c2cd9390fe3a45b2201dc (patch) | |
| tree | bb455b1e45f1fe32d45a856533c5e5bd0226abb7 /courgette | |
| parent | 5c41d034cae494882d07998955cfefc80981f2c8 (diff) | |
| download | chromium_src-d0f29e1666ab81289f7c2cd9390fe3a45b2201dc.zip chromium_src-d0f29e1666ab81289f7c2cd9390fe3a45b2201dc.tar.gz chromium_src-d0f29e1666ab81289f7c2cd9390fe3a45b2201dc.tar.bz2 | |
Cleanup: Pass std::string as const reference from courgette/
Passing std::string by reference can prevent extra copying of object.
BUG=367418
TEST=
R=wfh@chromium.org
Review URL: https://codereview.chromium.org/1353333002
Cr-Commit-Position: refs/heads/master@{#349951}
Diffstat (limited to 'courgette')
| -rw-r--r-- | courgette/ensemble_unittest.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/courgette/ensemble_unittest.cc b/courgette/ensemble_unittest.cc index b255ae9..9b4c2dd 100644 --- a/courgette/ensemble_unittest.cc +++ b/courgette/ensemble_unittest.cc @@ -20,17 +20,16 @@ class EnsembleTest : public BaseTest { public: - - void TestEnsemble(std::string src_bytes, std::string tgt_bytes) const; + void TestEnsemble(const std::string& src_bytes, + const std::string& tgt_bytes) const; void PeEnsemble() const; void Pe64Ensemble() const; void Elf32Ensemble() const; }; -void EnsembleTest::TestEnsemble(std::string src_bytes, - std::string tgt_bytes) const { - +void EnsembleTest::TestEnsemble(const std::string& src_bytes, + const std::string& tgt_bytes) const { courgette::SourceStream source; courgette::SourceStream target; |