diff options
author | dgarrett@chromium.org <dgarrett@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-17 00:33:37 +0000 |
---|---|---|
committer | dgarrett@chromium.org <dgarrett@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-17 00:33:37 +0000 |
commit | dc07cbc53bbc59170c1e1a8368893d80711e82cb (patch) | |
tree | 95f5bf6f6c26c6fbc4eba054f728ef4e47ae4647 /courgette | |
parent | 92e1b7e9feaf90c23af9ff0441cb4ed6ee6b1c3a (diff) | |
download | chromium_src-dc07cbc53bbc59170c1e1a8368893d80711e82cb.zip chromium_src-dc07cbc53bbc59170c1e1a8368893d80711e82cb.tar.gz chromium_src-dc07cbc53bbc59170c1e1a8368893d80711e82cb.tar.bz2 |
Add a basic backwards compatibility unittest.
This verifies we can still apply old patches, but does not
verify that old clients can apply new patches. That seems
important, but I'm not sure how to do it without storing
old client binaries in version control.
BUG=None
TEST=New Unittest
Review URL: http://codereview.chromium.org/7915007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101606 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'courgette')
-rw-r--r-- | courgette/courgette.gyp | 3 | ||||
-rw-r--r-- | courgette/testdata/setup1-setup2.v1.patch | 0 | ||||
-rw-r--r-- | courgette/versioning_unittest.cc | 83 |
3 files changed, 85 insertions, 1 deletions
diff --git a/courgette/courgette.gyp b/courgette/courgette.gyp index e9fa170..5a183e8 100644 --- a/courgette/courgette.gyp +++ b/courgette/courgette.gyp @@ -1,4 +1,4 @@ -# Copyright (c) 2009 The Chromium Authors. All rights reserved. +# Copyright (c) 2011 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -92,6 +92,7 @@ 'image_info_unittest.cc', 'run_all_unittests.cc', 'streams_unittest.cc', + 'versioning_unittest.cc', 'third_party/paged_array_unittest.cc' ], 'dependencies': [ diff --git a/courgette/testdata/setup1-setup2.v1.patch b/courgette/testdata/setup1-setup2.v1.patch new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/courgette/testdata/setup1-setup2.v1.patch diff --git a/courgette/versioning_unittest.cc b/courgette/versioning_unittest.cc new file mode 100644 index 0000000..34a6ca1 --- /dev/null +++ b/courgette/versioning_unittest.cc @@ -0,0 +1,83 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include <string> + +#include "base/path_service.h" +#include "base/file_util.h" +#include "base/string_util.h" + +#include "courgette/courgette.h" +#include "courgette/streams.h" + +#include "testing/gtest/include/gtest/gtest.h" + +class VersioningTest : public testing::Test { + public: + void TestApplyingOldPatch(const char* src_file, + const char* patch_file, + const char* expected_file) const; + + private: + void SetUp() { + PathService::Get(base::DIR_SOURCE_ROOT, &testdata_dir_); + testdata_dir_ = testdata_dir_.AppendASCII("courgette"); + testdata_dir_ = testdata_dir_.AppendASCII("testdata"); + } + + void TearDown() { } + + // Returns contents of |file_name| as uninterprested bytes stored in a string. + std::string FileContents(const char* file_name) const; + + FilePath testdata_dir_; // Full path name of testdata directory +}; + +// Reads a test file into a string. +std::string VersioningTest::FileContents(const char* file_name) const { + FilePath file_path = testdata_dir_; + file_path = file_path.AppendASCII(file_name); + std::string file_contents; + EXPECT_TRUE(file_util::ReadFileToString(file_path, &file_contents)); + return file_contents; +} + +void VersioningTest::TestApplyingOldPatch(const char* src_file, + const char* patch_file, + const char* expected_file) const { + + std::string old_buffer = FileContents(src_file); + std::string new_buffer = FileContents(patch_file); + std::string expected_buffer = FileContents(expected_file); + + courgette::SourceStream old_stream; + courgette::SourceStream patch_stream; + old_stream.Init(old_buffer); + patch_stream.Init(new_buffer); + + courgette::SinkStream generated_stream; + + courgette::Status status = + courgette::ApplyEnsemblePatch(&old_stream, + &patch_stream, + &generated_stream); + + EXPECT_EQ(status, courgette::C_OK); + + size_t expected_length = expected_buffer.size(); + size_t generated_length = generated_stream.Length(); + + EXPECT_EQ(generated_length, expected_length); + EXPECT_EQ(0, memcmp(generated_stream.Buffer(), + expected_buffer.c_str(), + expected_length)); +} + + +TEST_F(VersioningTest, All) { + TestApplyingOldPatch("setup1.exe", "setup1-setup2.v1.patch", "setup2.exe"); + + // We also need a way to test that newly generated patches are appropriately + // applicable by older clients... not sure of the best way to do that. +} |