diff options
author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
---|---|---|
committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
commit | e59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch) | |
tree | 712268a7e9e1cd552f309d89641b2bed5ad06322 /crypto/ec_private_key_unittest.cc | |
parent | 31fcd34da3797bc49160620ef8c94a38652c0587 (diff) | |
download | chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2 |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'crypto/ec_private_key_unittest.cc')
-rw-r--r-- | crypto/ec_private_key_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crypto/ec_private_key_unittest.cc b/crypto/ec_private_key_unittest.cc index a052a9a..d2ec256 100644 --- a/crypto/ec_private_key_unittest.cc +++ b/crypto/ec_private_key_unittest.cc @@ -23,7 +23,7 @@ TEST(ECPrivateKeyUnitTest, OpenSSLStub) { // back the same exact public key, and the private key should have the same // value and elliptic curve params. TEST(ECPrivateKeyUnitTest, InitRandomTest) { - const std::string password1 = ""; + const std::string password1; const std::string password2 = "test"; scoped_ptr<crypto::ECPrivateKey> keypair1( @@ -86,7 +86,7 @@ TEST(ECPrivateKeyUnitTest, InitRandomTest) { } TEST(ECPrivateKeyUnitTest, BadPasswordTest) { - const std::string password1 = ""; + const std::string password1; const std::string password2 = "test"; scoped_ptr<crypto::ECPrivateKey> keypair1( |