diff options
| author | pkotwicz@chromium.org <pkotwicz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-31 21:57:31 +0000 |
|---|---|---|
| committer | pkotwicz@chromium.org <pkotwicz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-31 21:57:31 +0000 |
| commit | de68fde9be3924779dfeaf062273f22be294ec7d (patch) | |
| tree | 3448269d1c1f7e07cdd7d98c825d216421b7bf79 /crypto/mock_apple_keychain_mac.cc | |
| parent | 8a5d3e8cae23f8b75e56e37cfb7af946f2a0fcb1 (diff) | |
| download | chromium_src-de68fde9be3924779dfeaf062273f22be294ec7d.zip chromium_src-de68fde9be3924779dfeaf062273f22be294ec7d.tar.gz chromium_src-de68fde9be3924779dfeaf062273f22be294ec7d.tar.bz2 | |
iOS and non iOS use different decoder for SkBitmap to PNG.
Currently:
- Sync sends the favicon PNG data to the history database
- The history database sends a notification (indirectly) to sync that its favicon data has changed.
In the process of the 'updated data' being sent to sync,
the PNG data is decoded to ImageSkia and reencoded to PNG.
Sync receives the reencoded data.
Sync compares byte-for-byte the 'updated data' with the data that it has sent to the database.
If the data from sync was encoded by a different PNG codec than the one used natively, the 'updated data' doesn't match exactly and sync erroneously thinks that it has an update to push to the server.
This CL removes the decode/encode if possible in in FaviconUtil::SelectFaviconFramesFromPNGs to avoid pushing erroneous updates.
BUG=172053, 171465
Test=SingleClientBookmarksSyncTest.SetFaviconHiDPIDifferentCodec
Review URL: https://chromiumcodereview.appspot.com/12034002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179974 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'crypto/mock_apple_keychain_mac.cc')
0 files changed, 0 insertions, 0 deletions