diff options
| author | wez <wez@chromium.org> | 2015-10-20 10:55:57 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-20 17:56:53 +0000 |
| commit | b6f20ed025663c5f2d23abee53015c11cbcaa5e3 (patch) | |
| tree | 6075225688b418d70d1eae704b8f173288b33e99 /crypto | |
| parent | 2094404d35eef8efc6a35f4b4ff59fcd7ba5f057 (diff) | |
| download | chromium_src-b6f20ed025663c5f2d23abee53015c11cbcaa5e3.zip chromium_src-b6f20ed025663c5f2d23abee53015c11cbcaa5e3.tar.gz chromium_src-b6f20ed025663c5f2d23abee53015c11cbcaa5e3.tar.bz2 | |
Remove work-around for compiler tree-vectorization bug in P224.
This work-around was added because a compiler bug broke the P224
implementation in Official builds, which in turn caused Chromoting's
SPAKE2-based key exchange to fail.
BUG=439566
TEST=Run Chrome Remote Desktop on an official ChromeOS build and verify that it is possible to authenticate to hosts.
Review URL: https://codereview.chromium.org/1415503003
Cr-Commit-Position: refs/heads/master@{#355100}
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/p224.cc | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/crypto/p224.cc b/crypto/p224.cc index 11946a9..a86163f 100644 --- a/crypto/p224.cc +++ b/crypto/p224.cc @@ -123,15 +123,6 @@ typedef uint64 LargeFieldElement[15]; // ReduceLarge converts a LargeFieldElement to a FieldElement. // // in[i] < 2**62 - -// GCC 4.9 incorrectly vectorizes the first coefficient elimination loop, so -// disable that optimization via pragma. Don't use the pragma under Clang, since -// clang doesn't understand it. -// TODO(wez): Remove this when crbug.com/439566 is fixed. -#if defined(__GNUC__) && !defined(__clang__) -#pragma GCC optimize("no-tree-vectorize") -#endif - void ReduceLarge(FieldElement* out, LargeFieldElement* inptr) { LargeFieldElement& in(*inptr); @@ -173,12 +164,6 @@ void ReduceLarge(FieldElement* out, LargeFieldElement* inptr) { // out[5..7] < 2**28 } -// TODO(wez): Remove this when crbug.com/439566 is fixed. -#if defined(__GNUC__) && !defined(__clang__) -// Reenable "tree-vectorize" optimization if it got disabled for ReduceLarge. -#pragma GCC reset_options -#endif - // Mul computes *out = a*b // // a[i] < 2**29, b[i] < 2**30 (or vice versa) |