diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-12 23:47:13 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-12 23:47:13 +0000 |
| commit | 5cb8eb22c86aa1c1461a8a55865945cb2da6cc16 (patch) | |
| tree | ebc6a18ae3d7f013cf1f6f4ea99e6d93906108c2 /dbus | |
| parent | 629b91c240a2e3d01e5ca9a5de76b66f7116bf38 (diff) | |
| download | chromium_src-5cb8eb22c86aa1c1461a8a55865945cb2da6cc16.zip chromium_src-5cb8eb22c86aa1c1461a8a55865945cb2da6cc16.tar.gz chromium_src-5cb8eb22c86aa1c1461a8a55865945cb2da6cc16.tar.bz2 | |
dbus: Eliminate an irrelevant LOG(ERROR) from Bus::AddMatch().
Clients of the library cannot tell if a match rule has been already added or
not (we could expose such a function but not so useful). Hence LOG(ERROR)
is irrelevant here. Also update the comment in bus.h.
TEST=dbus_unittests
BUG=none
Review URL: http://codereview.chromium.org/8223021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105205 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'dbus')
| -rw-r--r-- | dbus/bus.cc | 2 | ||||
| -rw-r--r-- | dbus/bus.h | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/dbus/bus.cc b/dbus/bus.cc index 843739c..858f686 100644 --- a/dbus/bus.cc +++ b/dbus/bus.cc @@ -484,7 +484,7 @@ void Bus::AddMatch(const std::string& match_rule, DBusError* error) { AssertOnDBusThread(); if (match_rules_added_.find(match_rule) != match_rules_added_.end()) { - LOG(ERROR) << "Match rule already exists: " << match_rule; + VLOG(1) << "Match rule already exists: " << match_rule; return; } @@ -312,7 +312,8 @@ class Bus : public base::RefCountedThreadSafe<Bus> { // Instead, you should check if an incoming message is what you are // interested in, in the filter functions. // - // The same match rule must not be added more than once. + // The same match rule can be added more than once, but ignored from the + // second time. // // The match rule looks like: // "type='signal', interface='org.chromium.SomeInterface'". |