summaryrefslogtreecommitdiffstats
path: root/dbus
diff options
context:
space:
mode:
authorspang <spang@chromium.org>2015-04-27 12:45:43 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-27 19:45:50 +0000
commitee9dc849ffa2df2820381c31d5ba8200774d287a (patch)
tree68e9884fd2a2691c71b21a40f72b4ca92d36b9d0 /dbus
parentbc743cc147868ef8a21db6e2d8bb4c6386b96689 (diff)
downloadchromium_src-ee9dc849ffa2df2820381c31d5ba8200774d287a.zip
chromium_src-ee9dc849ffa2df2820381c31d5ba8200774d287a.tar.gz
chromium_src-ee9dc849ffa2df2820381c31d5ba8200774d287a.tar.bz2
Revert of Move ScopedFileDescriptor to dbus/file_descriptor.h (patchset #1 id:1 of https://codereview.chromium.org/1090243003/)
Reason for revert: Breaks shared_library build with broken exports: ./../dbus/dbus_export.h:20:65: error: ignoring attributes applied to class type 'scoped_ptr<dbus::FileDescriptor, dbus::FileDescriptor::Deleter>' outside of definition [-Werror=attributes] #define CHROME_DBUS_EXPORT __attribute__((visibility("default"))) ^ ../../dbus/file_descriptor.h:81:57: note: in expansion of macro 'CHROME_DBUS_EXPORT' scoped_ptr<FileDescriptor, FileDescriptor::Deleter> CHROME_DBUS_EXPORT; Original issue's description: > Move ScopedFileDescriptor to dbus/file_descriptor.h > > ScopedFileDescriptor was initially introduced to facilitate the > management of a 'lifeline' FD used when asking permission_broker to > open a port in the device's firewall on CrOS. It's actually a scoped > wrapper around DBus::FileDescriptor, not a platform file descriptor. I > would like to use it to facilitate some other similar functionality in > which I create a pipe and pass one end over DBus, so it seems like a > good idea to move ScopedFileDescriptor into the dbus library directly. > > BUG=chromium:481340 > TEST=FirewallHole unit tests still pass > STATUS=Fixed > R=keybuk, reillyg, stevenjb > > Committed: https://crrev.com/b44fbaabbe9f91e63ad8aa164609a6b31e0de57e > Cr-Commit-Position: refs/heads/master@{#327089} TBR=keybuk@chromium.org,reillyg@chromium.org,stevenjb@chromium.org,cmasone@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481340 Review URL: https://codereview.chromium.org/1108893003 Cr-Commit-Position: refs/heads/master@{#327103}
Diffstat (limited to 'dbus')
-rw-r--r--dbus/file_descriptor.cc9
-rw-r--r--dbus/file_descriptor.h10
2 files changed, 0 insertions, 19 deletions
diff --git a/dbus/file_descriptor.cc b/dbus/file_descriptor.cc
index e607fc0..d2d6a31 100644
--- a/dbus/file_descriptor.cc
+++ b/dbus/file_descriptor.cc
@@ -2,21 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/bind.h"
#include "base/files/file.h"
-#include "base/location.h"
#include "base/logging.h"
-#include "base/threading/worker_pool.h"
#include "dbus/file_descriptor.h"
namespace dbus {
-void CHROME_DBUS_EXPORT FileDescriptor::Deleter::operator()(
- FileDescriptor* fd) {
- base::WorkerPool::PostTask(
- FROM_HERE, base::Bind(&base::DeletePointer<FileDescriptor>, fd), false);
-}
-
FileDescriptor::~FileDescriptor() {
if (owner_)
base::File auto_closer(value_);
diff --git a/dbus/file_descriptor.h b/dbus/file_descriptor.h
index 1e62c87..19e0b1a 100644
--- a/dbus/file_descriptor.h
+++ b/dbus/file_descriptor.h
@@ -6,7 +6,6 @@
#define DBUS_FILE_DESCRIPTOR_H_
#include "base/basictypes.h"
-#include "base/memory/scoped_ptr.h"
#include "dbus/dbus_export.h"
namespace dbus {
@@ -34,12 +33,6 @@ namespace dbus {
// with i/o restrictions.
class CHROME_DBUS_EXPORT FileDescriptor {
public:
- // This provides a simple way to pass around file descriptors since they must
- // be closed on a thread that is allowed to perform I/O.
- struct Deleter {
- void CHROME_DBUS_EXPORT operator()(FileDescriptor* fd);
- };
-
// Permits initialization without a value for passing to
// dbus::MessageReader::PopFileDescriptor to fill in and from int values.
FileDescriptor() : value_(-1), owner_(false), valid_(false) {}
@@ -77,9 +70,6 @@ class CHROME_DBUS_EXPORT FileDescriptor {
DISALLOW_COPY_AND_ASSIGN(FileDescriptor);
};
-using ScopedFileDescriptor =
- scoped_ptr<FileDescriptor, FileDescriptor::Deleter> CHROME_DBUS_EXPORT;
-
} // namespace dbus
#endif // DBUS_FILE_DESCRIPTOR_H_